Address review comments

Author: p-sawicki

mypyc/irbuild/specialize.py

@@ -14,7 +14,7 @@
 
 from __future__ import annotations
 
-from typing import Callable, Optional
+from typing import Callable, Final, Optional
 
 from mypy.nodes import (
     ARG_NAMED,
@@ -546,7 +546,7 @@ def gen_inner_stmts() -> None:
     return retval
 
 
-isinstance_primitives = {"list": isinstance_list}
+isinstance_primitives: Final = {"builtins.list": isinstance_list}
 
 
 @specialize_function("builtins.isinstance")
@@ -575,7 +575,7 @@ def translate_isinstance(builder: IRBuilder, expr: CallExpr, callee: RefExpr) ->
     if isinstance(expr.args[1], RefExpr):
         node = expr.args[1].node
         if node:
-            desc = isinstance_primitives.get(node.name)
+            desc = isinstance_primitives.get(node.fullname)
             if desc:
                 obj = builder.accept(expr.args[0])
                 return builder.primitive_op(desc, [obj], expr.line)

mypyc/test-data/run-lists.test

@@ -539,12 +539,31 @@ def test_sorted() -> None:
     assert sorted({2: "", 1: "", 3: ""}) == res
 
 [case testIsInstance]
+from copysubclass import subc
 def test() -> None:
     assert isinstance([], list)
     assert isinstance([1,2,3], list)
     assert isinstance(['a','b'], list)
+    assert isinstance(subc(), list)
+    assert isinstance(subc([1,2,3]), list)
+    assert isinstance(subc(['a','b']), list)
 
     assert not isinstance({}, list)
     assert not isinstance((), list)
+    assert not isinstance((1,2,3), list)
+    assert not isinstance(('a','b'), list)
     assert not isinstance(1, list)
     assert not isinstance('a', list)
+
+[file copysubclass.py]
+from typing import Any
+class subc(list[Any]):
+    pass
+
+[case testUserDefinedList]
+class list:
+    pass
+
+def test() -> None:
+    assert isinstance(list(), list)
+    assert not isinstance([list()], list)