else_irrelevant_for_possibly_undefined -> unreachable_else

Author: tyralla

mypy/checker.py

@@ -5036,7 +5036,7 @@ def visit_if_stmt(self, s: IfStmt) -> None:
 
                 if_map, else_map = self.find_isinstance_check(e)
 
-                s.else_irrelevant_for_possibly_undefined = else_map is None
+                s.unreachable_else = else_map is None
 
                 # XXX Issue a warning if condition is always False?
                 with self.binder.frame_context(can_skip=True, fall_through=2):

mypy/nodes.py

@@ -1792,21 +1792,21 @@ def accept(self, visitor: StatementVisitor[T]) -> T:
 
 
 class IfStmt(Statement):
-    __slots__ = ("expr", "body", "else_body", "else_irrelevant_for_possibly_undefined")
+    __slots__ = ("expr", "body", "else_body", "unreachable_else")
 
     __match_args__ = ("expr", "body", "else_body", "else_body_irrelevant_for_possibly_undefined")
 
     expr: list[Expression]
     body: list[Block]
     else_body: Block | None
-    else_irrelevant_for_possibly_undefined: bool
+    unreachable_else: bool
 
     def __init__(self, expr: list[Expression], body: list[Block], else_body: Block | None) -> None:
         super().__init__()
         self.expr = expr
         self.body = body
         self.else_body = else_body
-        self.else_irrelevant_for_possibly_undefined = False
+        self.unreachable_else = False
 
     def accept(self, visitor: StatementVisitor[T]) -> T:
         return visitor.visit_if_stmt(self)

mypy/partially_defined.py

@@ -395,7 +395,7 @@ def visit_if_stmt(self, o: IfStmt) -> None:
                 continue
             b.accept(self)
             self.tracker.next_branch()
-        if o.else_irrelevant_for_possibly_undefined:
+        if o.unreachable_else:
             self.tracker.skip_branch()
         elif o.else_body:
             if o.else_body.is_unreachable: