Refactor tolower_ucs4 and toupper_ucs4 functions by removing fallback logic for non-ASCII characters

Jahongir-Qurbonov · Jahongir-Qurbonov · commit 8065f9cfeade · 2025-07-06T16:42:15.000+05:00
diff --git a/mypyc/lib-rt/str_ops.c b/mypyc/lib-rt/str_ops.c
@@ -575,24 +575,14 @@ static inline Py_UCS4 tolower_ucs4(Py_UCS4 ch) {
     if (ch < 128) {
         return ascii_lower_table[ch];
     }
-#ifdef Py_UNICODE_TOLOWER
     return Py_UNICODE_TOLOWER(ch);
-#else
-    // fallback: no-op for non-ASCII if macro is unavailable
-    return ch;
-#endif
 }
 
 static inline Py_UCS4 toupper_ucs4(Py_UCS4 ch) {
     if (ch < 128) {
         return ascii_upper_table[ch];
     }
-#ifdef Py_UNICODE_TOUPPER
     return Py_UNICODE_TOUPPER(ch);
-#else
-    // fallback: no-op for non-ASCII if macro is unavailable
-    return ch;
-#endif
 }
 
 // Implementation of s.lower()

Original file line number	Diff line number	Diff line change
`@@ -575,24 +575,14 @@ static inline Py_UCS4 tolower_ucs4(Py_UCS4 ch) {`
`575`	`575`	`if (ch < 128) {`
`576`	`576`	`return ascii_lower_table[ch];`
`577`	`577`	`}`
`578`		`-#ifdef Py_UNICODE_TOLOWER`
`579`	`578`	`return Py_UNICODE_TOLOWER(ch);`
`580`		`-#else`
`581`		`- // fallback: no-op for non-ASCII if macro is unavailable`
`582`		`- return ch;`
`583`		`-#endif`
`584`	`579`	`}`
`585`	`580`
`586`	`581`	`static inline Py_UCS4 toupper_ucs4(Py_UCS4 ch) {`
`587`	`582`	`if (ch < 128) {`
`588`	`583`	`return ascii_upper_table[ch];`
`589`	`584`	`}`
`590`		`-#ifdef Py_UNICODE_TOUPPER`
`591`	`585`	`return Py_UNICODE_TOUPPER(ch);`
`592`		`-#else`
`593`		`- // fallback: no-op for non-ASCII if macro is unavailable`
`594`		`- return ch;`
`595`		`-#endif`
`596`	`586`	`}`
`597`	`587`
`598`	`588`	`// Implementation of s.lower()`