Skip to content

Commit 89d11a6

Browse files
committed
remove _MANGLE_ARGS -> never mangle parameter names
1 parent 0acbd5a commit 89d11a6

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

mypy/fastparse.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -364,8 +364,6 @@ class NameMangler(ast3.NodeTransformer):
364364
_mangle_annotations: bool
365365
_unmangled_args: set[str]
366366

367-
_MANGLE_ARGS: bool = False # ToDo: remove it or make it an option?
368-
369367
def __init__(self, classname: str, mangle_annotations: bool) -> None:
370368
self._classname_complete = classname
371369
self._classname_trimmed = classname.lstrip("_")
@@ -407,8 +405,7 @@ def visit_ClassDef(self, node: ast3.ClassDef) -> ast3.ClassDef:
407405

408406
def _visit_funcdef(self, node: _T_FuncDef) -> _T_FuncDef:
409407
node.name = self._mangle_name(node.name)
410-
if not self._MANGLE_ARGS:
411-
self = NameMangler(self._classname_complete, self._mangle_annotations)
408+
self = NameMangler(self._classname_complete, self._mangle_annotations)
412409
self.visit(node.args)
413410
for dec in node.decorator_list:
414411
self.visit(dec)
@@ -425,10 +422,7 @@ def visit_AsyncFunctionDef(self, node: ast3.AsyncFunctionDef) -> ast3.AsyncFunct
425422
return self._visit_funcdef(node)
426423

427424
def visit_arg(self, node: ast3.arg) -> ast3.arg:
428-
if self._MANGLE_ARGS:
429-
node.arg = self._mangle_name(node.arg)
430-
else:
431-
self._unmangled_args.add(node.arg)
425+
self._unmangled_args.add(node.arg)
432426
if self._mangle_annotations and (node.annotation is not None):
433427
self.visit(node.annotation)
434428
return node
@@ -447,7 +441,7 @@ def visit_Attribute(self, node: ast3.Attribute) -> ast3.Attribute:
447441
return node
448442

449443
def visit_Name(self, node: Name) -> Name:
450-
if self._MANGLE_ARGS or (node.id not in self._unmangled_args):
444+
if node.id not in self._unmangled_args:
451445
node.id = self._mangle_name(node.id)
452446
return node
453447

0 commit comments

Comments
 (0)