Fix detection of (nested) placeholder types

brianschubert · brianschubert · commit 8cc1aee0318f · 2024-11-25T12:33:34.000-05:00
diff --git a/mypy/semanal.py b/mypy/semanal.py
@@ -5046,8 +5046,7 @@ def analyze_value_types(self, items: list[Expression]) -> list[Type]:
                     analyzed = PlaceholderType(None, [], node.line)
 
                 # has_no_typevars does not work with PlaceholderType.
-                typ = get_proper_type(analyzed)
-                if not isinstance(typ, PlaceholderType) and not has_no_typevars(typ):
+                if not has_placeholder(analyzed) and not has_no_typevars(analyzed):
                     self.fail(
                         "TypeVar constraint type cannot be parametrized by type variables", node
                     )

Original file line number	Diff line number	Diff line change
`@@ -5046,8 +5046,7 @@ def analyze_value_types(self, items: list[Expression]) -> list[Type]:`
`5046`	`5046`	`analyzed = PlaceholderType(None, [], node.line)`
`5047`	`5047`
`5048`	`5048`	`# has_no_typevars does not work with PlaceholderType.`
`5049`		`- typ = get_proper_type(analyzed)`
`5050`		`- if not isinstance(typ, PlaceholderType) and not has_no_typevars(typ):`
	`5049`	`+ if not has_placeholder(analyzed) and not has_no_typevars(analyzed):`
`5051`	`5050`	`self.fail(`
`5052`	`5051`	`"TypeVar constraint type cannot be parametrized by type variables", node`
`5053`	`5052`	`)`