Address CR

Author: ilevkivskyi

mypyc/lib-rt/librt_internal.c

@@ -367,7 +367,7 @@ read_bytes_internal(PyObject *data) {
         _CHECK_READ(data, sizeof(CPyTagged), NULL)
         size = _READ(data, Py_ssize_t)
     }
-    // Read byes content.
+    // Read bytes content.
     char *buf = ((BufferObject *)data)->buf;
     _CHECK_READ(data, size, NULL)
     PyObject *res = PyBytes_FromStringAndSize(
@@ -394,10 +394,10 @@ static char
 write_bytes_internal(PyObject *data, PyObject *value) {
     _CHECK_BUFFER(data, CPY_NONE_ERROR)
 
-    Py_ssize_t size = PyBytes_GET_SIZE(value);
     const char *chunk = PyBytes_AsString(value);
     if (unlikely(chunk == NULL))
         return CPY_NONE_ERROR;
+    Py_ssize_t size = PyBytes_GET_SIZE(value);
 
     Py_ssize_t need;
     // Write length.

mypyc/test-data/run-classes.test

@@ -2735,6 +2735,9 @@ def test_buffer_roundtrip() -> None:
     write_bool(b, False)
     write_bytes(b, b"bar")
     write_bytes(b, b"bar" * 100)
+    write_bytes(b, b"")
+    write_bytes(b, b"a" * 127)
+    write_bytes(b, b"a" * 128)
     write_float(b, 0.1)
     write_int(b, 0)
     write_int(b, 1)
@@ -2756,6 +2759,9 @@ def test_buffer_roundtrip() -> None:
     assert read_bool(b) is False
     assert read_bytes(b) == b"bar"
     assert read_bytes(b) == b"bar" * 100
+    assert read_bytes(b) == b""
+    assert read_bytes(b) == b"a" * 127
+    assert read_bytes(b) == b"a" * 128
     assert read_float(b) == 0.1
     assert read_int(b) == 0
     assert read_int(b) == 1
@@ -2812,6 +2818,9 @@ def test_buffer_roundtrip_interpreted() -> None:
     write_bool(b, False)
     write_bytes(b, b"bar")
     write_bytes(b, b"bar" * 100)
+    write_bytes(b, b"")
+    write_bytes(b, b"a" * 127)
+    write_bytes(b, b"a" * 128)
     write_float(b, 0.1)
     write_int(b, 0)
     write_int(b, 1)
@@ -2833,6 +2842,9 @@ def test_buffer_roundtrip_interpreted() -> None:
     assert read_bool(b) is False
     assert read_bytes(b) == b"bar"
     assert read_bytes(b) == b"bar" * 100
+    assert read_bytes(b) == b""
+    assert read_bytes(b) == b"a" * 127
+    assert read_bytes(b) == b"a" * 128
     assert read_float(b) == 0.1
     assert read_int(b) == 0
     assert read_int(b) == 1