Clean up

Author: JukkaL

mypyc/irbuild/ll_builder.py

@@ -139,7 +139,6 @@
 from mypyc.primitives.generic_ops import (
     generic_len_op,
     generic_ssize_t_len_op,
-    not_op,
     py_call_op,
     py_call_with_kwargs_op,
     py_call_with_posargs_op,
@@ -1659,13 +1658,15 @@ def _non_specialized_unary_op(self, value: Value, op: str, line: int) -> Value:
         return target
 
     def unary_not(self, value: Value, line: int) -> Value:
+        """Perform unary 'not'."""
         typ = value.type
         if is_bool_or_bit_rprimitive(typ):
             mask = Integer(1, value.type, line)
             return self.int_op(value.type, value, mask, IntOp.XOR, line)
         return self._non_specialized_unary_op(value, "not", line)
 
     def unary_minus(self, value: Value, line: int) -> Value:
+        """Perform unary '-'."""
         typ = value.type
         if isinstance(value, Integer):
             # TODO: Overflow? Unsigned?
@@ -1680,6 +1681,7 @@ def unary_minus(self, value: Value, line: int) -> Value:
         return self._non_specialized_unary_op(value, "-", line)
 
     def unary_plus(self, value: Value, line: int) -> Value:
+        """Perform unary '+'."""
         typ = value.type
         if (
             is_tagged(typ)
@@ -1691,6 +1693,7 @@ def unary_plus(self, value: Value, line: int) -> Value:
         return self._non_specialized_unary_op(value, "+", line)
 
     def unary_invert(self, value: Value, line: int) -> Value:
+        """Perform unary '~'."""
         typ = value.type
         if is_fixed_width_rtype(typ):
             if typ.is_signed:
@@ -1702,16 +1705,17 @@ def unary_invert(self, value: Value, line: int) -> Value:
                 return self.int_op(typ, value, Integer(mask, typ), IntOp.XOR, line)
         return self._non_specialized_unary_op(value, "~", line)
 
-    def unary_op(self, value: Value, expr_op: str, line: int) -> Value:
-        if expr_op == "not":
+    def unary_op(self, value: Value, op: str, line: int) -> Value:
+        """Perform a unary operation."""
+        if op == "not":
             return self.unary_not(value, line)
-        elif expr_op == "-":
+        elif op == "-":
             return self.unary_minus(value, line)
-        elif expr_op == "+":
+        elif op == "+":
             return self.unary_plus(value, line)
-        elif expr_op == "~":
+        elif op == "~":
             return self.unary_invert(value, line)
-        raise RuntimeError("Unsupported unary operation: %s" % expr_op)
+        raise RuntimeError("Unsupported unary operation: %s" % op)
 
     def make_dict(self, key_value_pairs: Sequence[DictEntry], line: int) -> Value:
         result: Value | None = None

mypyc/primitives/generic_ops.py

@@ -158,7 +158,7 @@
         priority=0,
     )
 
-not_op = unary_op(
+unary_op(
     name="not",
     arg_type=object_rprimitive,
     return_type=c_int_rprimitive,