Address PR review

Author: A5rocks

mypy/checkexpr.py

@@ -4296,12 +4296,8 @@ def check_boolean_op(self, e: OpExpr, context: Context) -> Type:
         elif e.op == "or":
             left_map, right_map = self.chk.find_isinstance_check(e.left)
 
-        left_impossible = left_map is None or any(
-            isinstance(get_proper_type(v), UninhabitedType) for v in left_map.values()
-        )
-        right_impossible = right_map is None or any(
-            isinstance(get_proper_type(v), UninhabitedType) for v in right_map.values()
-        )
+        left_impossible = is_impossible_map(left_map)
+        right_impossible = is_impossible_map(right_map)
 
         # If left_map is None then we know mypy considers the left expression
         # to be redundant.
@@ -5835,13 +5831,9 @@ def check_for_comp(self, e: GeneratorExpr | DictionaryComprehension) -> None:
                     self.chk.push_type_map(true_map)
 
                 if codes.REDUNDANT_EXPR in self.chk.options.enabled_error_codes:
-                    if true_map is None or any(
-                        isinstance(get_proper_type(t), UninhabitedType) for t in true_map.values()
-                    ):
+                    if is_impossible_map(true_map):
                         self.msg.redundant_condition_in_comprehension(False, condition)
-                    elif false_map is None or any(
-                        isinstance(get_proper_type(t), UninhabitedType) for t in false_map.values()
-                    ):
+                    elif is_impossible_map(false_map):
                         self.msg.redundant_condition_in_comprehension(True, condition)
 
     def visit_conditional_expr(self, e: ConditionalExpr, allow_none_return: bool = False) -> Type:
@@ -5852,13 +5844,9 @@ def visit_conditional_expr(self, e: ConditionalExpr, allow_none_return: bool = F
         # but only for the current expression
         if_map, else_map = self.chk.find_isinstance_check(e.cond)
         if codes.REDUNDANT_EXPR in self.chk.options.enabled_error_codes:
-            if if_map is None or any(
-                isinstance(get_proper_type(t), UninhabitedType) for t in if_map.values()
-            ):
+            if is_impossible_map(if_map):
                 self.msg.redundant_condition_in_if(False, e.cond)
-            elif else_map is None or any(
-                isinstance(get_proper_type(t), UninhabitedType) for t in else_map.values()
-            ):
+            elif is_impossible_map(else_map):
                 self.msg.redundant_condition_in_if(True, e.cond)
 
         if_type = self.analyze_cond_branch(
@@ -5946,9 +5934,7 @@ def analyze_cond_branch(
         with self.chk.binder.frame_context(can_skip=True, fall_through=0):
             self.chk.push_type_map(map)
 
-            if map is None or any(
-                isinstance(get_proper_type(t), UninhabitedType) for t in map.values()
-            ):
+            if is_impossible_map(map):
                 # We still need to type check node, in case we want to
                 # process it for isinstance checks later. Since the branch was
                 # determined to be unreachable, any errors should be suppressed.
@@ -6757,3 +6743,14 @@ def is_type_type_context(context: Type | None) -> bool:
     if isinstance(context, UnionType):
         return any(is_type_type_context(item) for item in context.items)
     return False
+
+
+def is_impossible_map(map: mypy.checker.TypeMap) -> bool:
+    if map is None:
+        return True
+
+    for v in map.values():
+        if isinstance(get_proper_type(v), UninhabitedType):
+            return True
+
+    return False

mypyc/ir/pprint.py

@@ -221,17 +221,8 @@ def visit_call_c(self, op: CallC) -> str:
 
     def visit_primitive_op(self, op: PrimitiveOp) -> str:
         args = []
-        arg_index = 0
-        # type_arg_index = 0
-        for arg_type in zip(op.desc.arg_types):
-            if arg_type:
-                args.append(self.format("%r", op.args[arg_index]))
-                arg_index += 1
-            else:
-                assert False
-                # assert op.type_args
-                # args.append(self.format("%r", op.type_args[type_arg_index]))
-                # type_arg_index += 1
+        for arg in op.args:
+            args.append(self.format("%r", arg))
 
         args_str = ", ".join(args)
         if op.is_void: