Made Pydantic tests leaner; Removed extra variable in stubgen.

Author: teplandr

mypy/stubgen.py

@@ -861,15 +861,13 @@ def visit_class_def(self, o: ClassDef) -> None:
         if self.analyzed and (spec := find_dataclass_transform_spec(o)):
             self.processing_dataclass = True
             self.dataclass_field_specifier = spec.field_specifiers
-        is_pydantic_model = False
         for base_type_expr in o.base_type_exprs:
             if (
                 isinstance(base_type_expr, (NameExpr, MemberExpr))
                 and self.get_fullname(base_type_expr) == "pydantic.BaseModel"
             ):
-                is_pydantic_model = True
+                self.processing_pydantic_model = True
                 break
-        self.processing_pydantic_model = is_pydantic_model
         super().visit_class_def(o)
         self.dedent()
         self._vars.pop()

test-data/unit/stubgen.test

@@ -4756,15 +4756,17 @@ from _typeshed import Incomplete
 
 def polar(*args, **kwargs) -> Incomplete: ...
 
-
 [case testPydanticBaseModel]
 import pydantic
+from typing import Dict, List, Optional, Union
 
 class User(pydantic.BaseModel):
     id: int
     name: str
     active: bool = True
     optional_field: str | None = None
+    tags: List[str] = []
+    properties: Dict[str, Union[str, int, float, bool]] = {}
 [out]
 import pydantic
 
@@ -4773,22 +4775,8 @@ class User(pydantic.BaseModel):
     name: str
     active: bool = ...
     optional_field: str | None = ...
-
-[case testPydanticBaseModelWithAnnotationsOnly]
-import pydantic
-
-class ConfigSettings(pydantic.BaseModel):
-    # Fields without initialization
-    db_name: str
-    port: int
-    debug: bool
-[out]
-import pydantic
-
-class ConfigSettings(pydantic.BaseModel):
-    db_name: str
-    port: int
-    debug: bool
+    tags: list[str] = ...
+    properties: dict[str, str | int | float | bool] = ...
 
 [case testPydanticNestedBaseModel]
 from pydantic import BaseModel
@@ -4813,24 +4801,6 @@ class User(BaseModel):
     age: int
     address: Address | None = ...
 
-[case testPydanticBaseModelComplex]
-from pydantic import BaseModel
-from typing import Dict, List, Optional, Union
-
-class Item(BaseModel):
-    name: str
-    description: Optional[str] = None
-    tags: List[str] = []
-    properties: Dict[str, Union[str, int, float, bool]] = {}
-[out]
-from pydantic import BaseModel
-
-class Item(BaseModel):
-    name: str
-    description: str | None = ...
-    tags: list[str] = ...
-    properties: dict[str, str | int | float | bool] = ...
-
 [case testPydanticBaseModelInheritance]
 from pydantic import BaseModel
 
@@ -4840,7 +4810,7 @@ class BaseUser(BaseModel):
 
 class User(BaseUser):
     name: str
-    email: str
+    email: str = '@'
 [out]
 from pydantic import BaseModel
 
@@ -4850,7 +4820,7 @@ class BaseUser(BaseModel):
 
 class User(BaseUser):
     name: str
-    email: str
+    email: str = ...
 
 [case testPydanticModelWithMethods]
 from pydantic import BaseModel
@@ -4860,11 +4830,11 @@ class User(BaseModel):
     name: str
 
     def get_display_name(self) -> str:
-        return f"User {self.name}"
+        return 'a'
 
     @property
     def display_id(self) -> str:
-        return f"ID: {self.id}"
+        return 'b'
 [out]
 from pydantic import BaseModel