Fix: the cache should not be touched outside of overloads

Author: sterliakov

mypy/checkexpr.py

@@ -360,6 +360,8 @@ def __init__(
         self._args_cache: dict[tuple[int, ...], list[Type]] = {}
 
     def reset(self) -> None:
+        assert self.overload_stack_depth == 0
+        assert not self._args_cache
         self.resolved_type = {}
 
     def visit_name_expr(self, e: NameExpr) -> Type:
@@ -1682,7 +1684,7 @@ def check_call(
     def overload_context(self) -> Iterator[None]:
         self.overload_stack_depth += 1
         yield
-        self.overload_stack_depth -= 1
+        self.overload_stack_depth += 1
         if self.overload_stack_depth == 0:
             self._args_cache.clear()
 
@@ -1949,7 +1951,12 @@ def infer_arg_types_in_empty_context(self, args: list[Expression]) -> list[Type]
         In short, we basically recurse on each argument without considering
         in what context the argument was called.
         """
-        can_cache = not any(isinstance(t, TempNode) for t in args)
+        # We can only use this hack locally while checking a single nested overloaded
+        # call. This saves a lot of rechecking, but is not generally safe. Cache is
+        # pruned upon leaving the outermost overload.
+        can_cache = self.overload_stack_depth > 0 and not any(
+            isinstance(t, TempNode) for t in args
+        )
         key = tuple(map(id, args))
         if can_cache and key in self._args_cache:
             return self._args_cache[key]