Skip to content

Conversation

@cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Dec 29, 2024

Extracted from #18356

Comment on lines -26 to +27
def run_case(self, test_case: DataDrivenTestCase) -> None:
test_pep561(test_case)
def run_case(self, testcase: DataDrivenTestCase) -> None:
test_pep561(testcase)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18356 changed the superclass implementation instead. However as this is the only violation, I'm not sure that's necessary here.

mypy/mypy/test/data.py

Lines 818 to 820 in d79d89e

@abstractmethod
def run_case(self, testcase: DataDrivenTestCase) -> None:
raise NotImplementedError

@hauntsaninja hauntsaninja merged commit 3433a0e into python:master Dec 29, 2024
12 checks passed
@cdce8p cdce8p deleted the fix-subtypes-tests branch December 29, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants