[misc] automatically strip periods when generating changelog entries #18598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
reviewed
Feb 5, 2025
misc/generate_changelog.py
Outdated
| s += f" ({c.author})" | ||
| """ | ||
| s = f" * {c.title} ({c.author}" | ||
| s = f" * {c.title.removesuffix(".")} ({c.author}" |
Collaborator
There was a problem hiding this comment.
Suggested change
| s = f" * {c.title.removesuffix(".")} ({c.author}" | |
| s = f" * {c.title.removesuffix('.')} ({c.author}" |
Collaborator
Author
There was a problem hiding this comment.
I already had a local commit to fix this by breaking it out into a separate variable, but I logged off before remembering to push it, haha. I'm opting to keep that approach for the slight readability advantage.
hauntsaninja
approved these changes
Feb 5, 2025
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
…ython#18598) Manually removing the periods caused a small amount of busy work in the 1.15 release. It's easy enough to tweak the script, so I went ahead and added a `removesuffix` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually removing the periods caused a small amount of busy work in the 1.15 release. It's easy enough to tweak the script, so I went ahead and added a
removesuffixcall.