feat: type check alignment format specifiers #18799
Draft
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…o type_check_alignment
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Are you still working on this feature? My team is looking for an issue to work on. |
Author
|
I am not working on this - though it would be awesome to see it done. I also spawned this issue on the same topic: #18800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces support for type checking the
alignmentformat specifiersI ran into this issue where an optional type was being formatted with
<- butNonetypes do not actually support these alignment spec strings.I'm a little unsure how to approach this feature and what the overall philosophy for the format specs are - I don't know how one would write a complete list of the types that support a given spec type.
Inline (line 95) the code claims: