Skip to content

feat: type check alignment format specifiers #18799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: type check alignment format specifiers #18799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
563d7b8
feat: type check alignment format specifiers
jack-tutor Mar 13, 2025
67d23de
fix and add test case
jack-tutor Mar 13, 2025
89b3700
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 13, 2025
2ba0d84
set test to desired
jack-tutor Mar 13, 2025
f934298
Merge branch 'type_check_alignment' of github.com:jack-tutor/mypy int…
jack-tutor Mar 13, 2025
6c85e5f
improve comment in tests
jack-tutor Mar 13, 2025
6439b13
add inline comment
jack-tutor Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mypy/checkstrformat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,15 @@ def conversion_type(
return UnionType(
[self.named_type("builtins.int"), self.named_type("builtins.str")]
)
elif p.startswith(("<", ">", "=", "^")):
# THIS CODE IS WRONG
return UnionType(
[
self.named_type("builtins.int"),
self.named_type("builtins.float"),
self.named_type("builtins.str"),
]
)
else:
self.msg.unsupported_placeholder(p, context)
return None
Expand Down
2 changes: 2 additions & 0 deletions test-data/unit/check-errorcodes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,8 @@ def g() -> int:

'{}'.format(b'abc') # E: If x = b'abc' then f"{x}" or "{}".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"{x!r}" or "{!r}".format(x). Otherwise, decode the bytes [str-bytes-safe]
'%s' % b'abc' # E: If x = b'abc' then "%s" % x produces "b'abc'", not "abc". If this is desired behavior use "%r" % x. Otherwise, decode the bytes [str-bytes-safe]
'{:>2}'.format(None) # E: alignment format specs are not supported on NoneType [str-format]

[builtins fixtures/primitives.pyi]
[typing fixtures/typing-medium.pyi]

Expand Down
Loading