Skip to content

[mypyc] Add primitive for bytes decode() method #18931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[mypyc] Add primitive for bytes decode() method #18931

wants to merge 1 commit into from

Conversation

@EvgenyVashkevich
Copy link

@EvgenyVashkevich EvgenyVashkevich commented Apr 16, 2025

(Explain how this PR changes mypy.)

@brianschubert
Copy link
Member

brianschubert commented Apr 16, 2025

Thanks for the PR! However, it looks a primitive for bytes.decode already exists:

mypy/mypyc/primitives/str_ops.py

Lines 314 to 341 in a3ce6d5

# obj.decode()
method_op(
name="decode",
arg_types=[bytes_rprimitive],
return_type=str_rprimitive,
c_function_name="CPy_Decode",
error_kind=ERR_MAGIC,
extra_int_constants=[(0, pointer_rprimitive), (0, pointer_rprimitive)],
)
# obj.decode(encoding)
method_op(
name="decode",
arg_types=[bytes_rprimitive, str_rprimitive],
return_type=str_rprimitive,
c_function_name="CPy_Decode",
error_kind=ERR_MAGIC,
extra_int_constants=[(0, pointer_rprimitive)],
)
# obj.decode(encoding, errors)
method_op(
name="decode",
arg_types=[bytes_rprimitive, str_rprimitive, str_rprimitive],
return_type=str_rprimitive,
c_function_name="CPy_Decode",
error_kind=ERR_MAGIC,
)

@hauntsaninja hauntsaninja added the pending Issues that may be closed label Apr 17, 2025
A5rocks
A5rocks suggested changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already stated above mypy already has this implemented! For .decode(encoding) too, not just assuming encoding == "utf-8".

mypyc/test-data/irbuild-bytes.test

[case testDecodeUtf8]
def f(b: bytes) -> str:
return b.decode("utf-8")
Copy link
Collaborator

@A5rocks A5rocks Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it's silly to have a parameter when we only support "utf-8". It doesn't look like you have a fallback either but I don't really know mypyc.

@A5rocks A5rocks closed this Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@A5rocks A5rocks A5rocks requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pending Issues that may be closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EvgenyVashkevich @brianschubert @A5rocks @hauntsaninja