[mypyc] Add type annotations to tests #19794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypyc/test-data/run-dunders.test
Outdated
Comment on lines
630
to
635
| def __add__(self, x: Any) -> Any: | ||
| if isinstance(x, int): | ||
| return x + 1 | ||
| return NotImplemented | ||
|
|
||
| def __radd__(self, x): | ||
| def __radd__(self, x: Any) -> Any: |
Member
There was a problem hiding this comment.
Hmm, these are part of a case that seems to be explicitly testing unannotated behavior ("test_unannotated_add_and_radd_2") -- does annotating these with Any affect that?
Member
There was a problem hiding this comment.
Incidentally, I actually started a similar patch where I worked around cases like this by adding support for # flags: --allow-untyped-defs in the run tests
Collaborator
Author
There was a problem hiding this comment.
Reverted the annotations in this test case. Annotating with Any should have only the effect of turning on type checking and type inference in the function body.
Also test using Any types as well, just in case.
p-sawicki
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing type annotations can compromise test coverage. My eventual goal is to require annotations by default in all run tests.