[mypyc] feat: use exact dict getitem op for module dict lookup [1/1] #19999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
changed the title
BobTheBuidler
force-pushed
the
exact-dict-getitem-op
branch
from
bfd77b8 to
d8d25e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CPyDict_GetItemUnsafe op which can only be used on exact dict instances, and uses it to get items from module dicts and the globals dict.
I broke this out of #19499 because it doesn't depend on the exact_dict_rprimitive PR #19677 being merged beforehand. (could I ask you to look at that one next actually? Once its merged it unblocks me on the rest of the exact_dict optimizations)
This PR is ready for review.