[mypyc] Fix inheritance of async defs #20044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I'm still missing at least non-async generator inheritance tests. |
p-sawicki
approved these changes
Oct 13, 2025
JukkaL
added a commit
that referenced
this pull request
Nov 18, 2025
Disable optimization that doesn't work for trait methods. We could probably make the optimization work properly, but it would take significant work, so focus on fixing a regression. Fixes mypyc/mypyc#1141. #20044 was a previous fix attempt that fixes some other use cases, but it didn't address traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inferring a precise generator return type for an async def (or generator), make the generate returned by an override in a subclass inherit from the base class generator. This means that the environment has to be moved to a separate class in the base class generator.
Don't infer a precise generator return type when an override might have a less precise return type, since it would break LSP.
Fixes mypyc/mypyc#1141.