Skip to content

Commit 8a25d5d

Browse files
authored
PEP 728: Wording updates for clarity in certain sections (#3724)
1 parent 326a658 commit 8a25d5d

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

peps/pep-0728.rst

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -654,9 +654,9 @@ because such dict can be a subtype of dict::
654654
How to Teach This
655655
=================
656656

657-
The choice of ``"__extra_items__"`` and the requirement of ``closed=True``
658-
whenever it is used as a special key intended to make it more understandable to
659-
new users even without former knowledge of this feature.
657+
The choice of the spelling ``"__extra_items__"`` is intended to make this
658+
feature more understandable to new users compared to shorter alternatives like
659+
``"__extra__"``.
660660

661661
Details of this should be documented in both the typing spec and the
662662
:mod:`typing` documentation.
@@ -701,9 +701,10 @@ subtyping. ``closed=True`` plays a similar role in the current proposal.
701701
Supporting ``TypedDict(extra=type)``
702702
------------------------------------
703703

704-
While this design is potentially viable, there are several partially addressable
705-
concerns to consider. The author of this PEP thinks that it is slightly less
706-
favorable than the current proposal.
704+
During the discussion of the PEP, there were strong objections against adding
705+
another place where types are passed as values instead of annotations from some
706+
authors of type checkers. While this design is potentially viable, there are
707+
also several partially addressable concerns to consider.
707708

708709
- Usability of forward reference
709710
As in the functional syntax, using a quoted type or a type alias will be

0 commit comments

Comments
 (0)