PEP 757: mark as Final

Author: skirpichev

peps/pep-0757.rst

@@ -3,7 +3,7 @@ Title: C API to import-export Python integers
 Author: Sergey B Kirpichev <[email protected]>,
         Victor Stinner <[email protected]>
 Discussions-To: https://discuss.python.org/t/63895
-Status: Accepted
+Status: Final
 Type: Standards Track
 Created: 13-Sep-2024
 Python-Version: 3.14
@@ -67,11 +67,13 @@ functions.
 
    .. c:member:: uint8_t bits_per_digit
 
-      Bits per digit.
+      Bits per digit.  For example, a 15 bit digit means that bits 0-14
+      contain meaningful information.
 
    .. c:member:: uint8_t digit_size
 
-      Digit size in bytes.
+      Digit size in bytes.  For example, a 15 bit digit will require at least
+      2 bytes.
 
    .. c:member:: int8_t digits_order
 
@@ -85,7 +87,7 @@ functions.
       Digit endianness:
 
       - ``1`` for most significant byte first (big endian)
-      - ``-1`` for least significant first (little endian)
+      - ``-1`` for least significant byte first (little endian)
 
 
 .. c:function:: const PyLongLayout* PyLong_GetNativeLayout(void)
@@ -110,11 +112,9 @@ Export API
    There are two cases:
 
    * If :c:member:`digits` is ``NULL``, only use the :c:member:`value` member.
-     Calling :c:func:`PyLong_FreeExport` is optional in this case.
    * If :c:member:`digits` is not ``NULL``, use :c:member:`negative`,
      :c:member:`ndigits` and :c:member:`digits` members.
-     Calling :c:func:`PyLong_FreeExport` is mandatory in this case.
-
+ 
    .. c:member:: int64_t value
 
       The native integer value of the exported :class:`int` object.
@@ -145,11 +145,18 @@ If :c:member:`PyLongExport.digits` is not ``NULL``, a private field of the
 
    Export a Python :class:`int` object.
 
-   On success, set *\*export_long* and return 0.
+   *export_long* must point to a :c:struct:`PyLongExport` structure allocated
+   by the caller.  It must not be ``NULL``.
+
+   On success, fill in *\*export_long* and return 0.
    On error, set an exception and return -1.
 
-   If *export_long->digits* is not ``NULL``, :c:func:`PyLong_FreeExport` must be
-   called when the export is no longer needed.
+   :c:func:`PyLong_FreeExport` must be called when the export is no longer
+   needed.
+
+    .. impl-detail::
+        This function always succeeds if *obj* is a Python :class:`int` object
+        or a subclass.
 
 
 On CPython 3.14, no memory copy is needed in :c:func:`PyLong_Export`, it's just
@@ -160,12 +167,15 @@ a thin wrapper to expose Python :class:`int` internal digits array.
 
    Release the export *export_long* created by :c:func:`PyLong_Export`.
 
+   .. impl-detail::
+      Calling :c:func:`PyLong_FreeExport` is optional if *export_long->digits*
+      is ``NULL``.
+
 
 Import API
 ----------
 
-The :c:type:`PyLongWriter` API can be used to import an integer:
-create a Python :class:`int` object from a digits array.
+The :c:type:`PyLongWriter` API can be used to import an integer.
 
 .. c:struct:: PyLongWriter
 
@@ -187,12 +197,20 @@ create a Python :class:`int` object from a digits array.
    *ndigits* is the number of digits in the *digits* array.  It must be
    greater than 0.
 
-   The caller can either initialize the array of digits *digits* and then
-   either call :c:func:`PyLongWriter_Finish` to get a Python :class:`int` or
-   :c:func:`PyLongWriter_Discard` to destroy the writer instance.  Digits must
-   be in the range [``0``; ``(1 << bits_per_digit) - 1``]  (where the
-   :c:struct:`~PyLongLayout.bits_per_digit` is the number of bits per digit).
-   The unused most-significant digits must be set to ``0``.
+   *digits* must not be NULL.
+
+   After a successful call to this function, the caller should fill in the
+   array of digits *digits* and then call :c:func:`PyLongWriter_Finish` to get
+   a Python :class:`int`.
+   The layout of *digits* is described by :c:func:`PyLong_GetNativeLayout`.
+
+   Digits must be in the range [``0``; ``(1 << bits_per_digit) - 1``]
+   (where the :c:struct:`~PyLongLayout.bits_per_digit` is the number of bits
+   per digit).
+   Any unused most significant digits must be set to ``0``.
+
+   Alternately, call :c:func:`PyLongWriter_Discard` to destroy the writer
+   instance without creating an :class:`~int` object.
 
 
 On CPython 3.14, the :c:func:`PyLongWriter_Create` implementation is a thin
@@ -209,14 +227,16 @@ wrapper to the private :c:func:`!_PyLong_New()` function.
    The function takes care of normalizing the digits and converts the
    object to a compact integer if needed.
 
-   The writer instance is invalid after the call.
+   The writer instance and the *digits* array are invalid after the call.
 
 
 .. c:function:: void PyLongWriter_Discard(PyLongWriter *writer)
 
    Discard a :c:type:`PyLongWriter` created by :c:func:`PyLongWriter_Create`.
 
-   The writer instance is invalid after the call.
+   *writer* must not be ``NULL``.
+
+   The writer instance and the *digits* array are invalid after the call.
 
 
 Optimize import for small integers