ci: remove perms #515
Open
ci: remove perms #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
approved these changes
Oct 10, 2024
JacobCoffee
commented
Oct 10, 2024
| @@ -11,8 +11,6 @@ jobs: | |||
| remind: | |||
| if: github.event.pull_request.merged == true | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| issues: write | |||
| steps: | |||
| - name: Comment on PR | |||
| uses: actions/github-script@v7 | |||
There was a problem hiding this comment.
maybe should revert to v6
There was a problem hiding this comment.
ah, was it working before update?
There was a problem hiding this comment.
Doesn't look like we were ever using v6?
There was a problem hiding this comment.
im not sure anymore :\ this works on a private repo as many times as i can trigger it, but here it fails. both repos have the same perms in settings > actions, so im just confused on what the issue is.
it was working before the permissions add, then it wasn't
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description