Add test coverage for new code

Author: zooba

src/manage/install_command.py

@@ -351,7 +351,7 @@ def print_cli_shortcuts(cmd):
     verbose = LOGGER.would_log_to_console(VERBOSE)
     for i in installs:
         # We need to pre-filter aliases before getting the nice names.
-        aliases = [a for a in i["alias"] if a["name"].casefold() not in seen]
+        aliases = [a for a in i.get("alias", ()) if a["name"].casefold() not in seen]
         seen.update(n["name"].casefold() for n in aliases)
         if not verbose:
             if i.get("default"):

tests/conftest.py

@@ -201,7 +201,7 @@ def make_install(tag, **kwargs):
         run_for.append({"tag": t, "target": kwargs.get("target", "python.exe")})
         run_for.append({"tag": t, "target": kwargs.get("targetw", "pythonw.exe"), "windowed": 1})
 
-    return {
+    i = {
         "company": kwargs.get("company", "PythonCore"),
         "id": "{}-{}".format(kwargs.get("company", "PythonCore"), tag),
         "sort-version": kwargs.get("sort_version", tag),
@@ -212,12 +212,17 @@ def make_install(tag, **kwargs):
         "prefix": PurePath(kwargs.get("prefix", rf"C:\{tag}")),
         "executable": kwargs.get("executable", "python.exe"),
     }
+    try:
+        i["alias"] = kwargs["alias"]
+    except LookupError:
+        pass
+    return i
 
 
 def fake_get_installs(install_dir):
     yield make_install("1.0")
-    yield make_install("1.0-32", sort_version="1.0")
-    yield make_install("1.0-64", sort_version="1.0")
+    yield make_install("1.0-32", sort_version="1.0", alias=[dict(name="py1.0.exe"), dict(name="py1.0-32.exe")])
+    yield make_install("1.0-64", sort_version="1.0", alias=[dict(name="py1.0.exe"), dict(name="py1.0-64.exe")])
     yield make_install("2.0-64", sort_version="2.0")
     yield make_install("2.0-arm64", sort_version="2.0")
     yield make_install("3.0a1-32", sort_version="3.0a1")

tests/test_install_command.py

@@ -1,13 +1,17 @@
 import pytest
 import secrets
+from pathlib import PurePath
+
 from manage import install_command as IC
+from manage import installs
 
 
 @pytest.fixture
 def alias_checker(tmp_path):
     with AliasChecker(tmp_path) as checker:
         yield checker
 
+
 class AliasChecker:
     class Cmd:
         global_dir = "out"
@@ -95,3 +99,18 @@ def test_write_alias_default_platform(alias_checker):
 def test_write_alias_fallback_platform(alias_checker):
     alias_checker.check_64(alias_checker.Cmd("-spam"), "1.0", "testA")
     alias_checker.check_w64(alias_checker.Cmd("-spam"), "1.0", "testB")
+
+
+def test_print_cli_shortcuts(patched_installs, assert_log):
+    class Cmd:
+        global_dir = None
+        def get_installs(self):
+            return installs.get_installs(None)
+
+    IC.print_cli_shortcuts(Cmd())
+    print(assert_log)
+    assert_log(
+        assert_log.skip_until("Installed %s", ["Python 2.0-64", PurePath("C:\\2.0-64")]),
+        assert_log.skip_until("%s will be launched by %s", ["Python 1.0-64", "py1.0[-64].exe"]),
+        ("%s will be launched by %s", ["Python 1.0-32", "py1.0-32.exe"]),
+    )