Add test

Author: zooba

src/manage/aliasutils.py

@@ -127,9 +127,10 @@ def create_alias(cmd, install, alias, target, *, script_code=None, _link=os.link
 
 
 def _parse_entrypoint_line(line):
+    line = line.partition("#")[0]
     name, sep, rest = line.partition("=")
     name = name.strip()
-    if name and sep and rest:
+    if name and name[0].isalnum() and sep and rest:
         mod, sep, rest = rest.partition(":")
         mod = mod.strip()
         if mod and sep and rest:
@@ -140,40 +141,43 @@ def _parse_entrypoint_line(line):
     return None, None, None
 
 
+def _scan_one(root):
+    # Scan d for dist-info directories with entry_points.txt
+    dist_info = [d for d in root.glob("*.dist-info") if d.is_dir()]
+    LOGGER.debug("Found %i dist-info directories in %s", len(dist_info), root)
+    entrypoints = [f for f in [d / "entry_points.txt" for d in dist_info] if f.is_file()]
+    LOGGER.debug("Found %i entry_points.txt files in %s", len(entrypoints), root)
+
+    # Filter down to [console_scripts] and [gui_scripts]
+    for ep in entrypoints:
+        try:
+            f = open(ep, "r", encoding="utf-8", errors="strict")
+        except OSError:
+            LOGGER.debug("Failed to read %s", ep, exc_info=True)
+            continue
+
+        with f:
+            alias = None
+            for line in f:
+                if line.strip() == "[console_scripts]":
+                    alias = dict(windowed=0)
+                elif line.strip() == "[gui_scripts]":
+                    alias = dict(windowed=1)
+                elif line.lstrip().startswith("["):
+                    alias = None
+                elif alias is not None:
+                    name, mod, func = _parse_entrypoint_line(line)
+                    if name and mod and func:
+                        yield (
+                            {**alias, "name": name},
+                            f"import sys; from {mod} import {func}; sys.exit({func}())",
+                        )
+
+
 def _scan(prefix, dirs):
     for dirname in dirs or ():
         root = prefix / dirname
-
-        # Scan d for dist-info directories with entry_points.txt
-        dist_info = [d for d in root.listdir() if d.match("*.dist-info") and d.is_dir()]
-        LOGGER.debug("Found %i dist-info directories in %s", len(dist_info), root)
-        entrypoints = [f for f in [d / "entry_points.txt" for d in dist_info] if f.is_file()]
-        LOGGER.debug("Found %i entry_points.txt files in %s", len(entrypoints), root)
-
-        # Filter down to [console_scripts] and [gui_scripts]
-        for ep in entrypoints:
-            try:
-                f = open(ep, "r", encoding="utf-8", errors="strict")
-            except OSError:
-                LOGGER.debug("Failed to read %s", ep, exc_info=True)
-                continue
-
-            with f:
-                alias = None
-                for line in f:
-                    if line.strip() == "[console_scripts]":
-                        alias = dict(windowed=0)
-                    elif line.strip() == "[gui_scripts]":
-                        alias = dict(windowed=1)
-                    elif line.lstrip().startswith("["):
-                        alias = None
-                    elif alias is not None:
-                        name, mod, func = _parse_entrypoint_line(line)
-                        if name and mod and func:
-                            yield (
-                                {**alias, "name": name},
-                                f"import sys; from {mod} import {func}; sys.exit({func}())",
-                            )
+        yield from _scan_one(root)
 
 
 def scan_and_create_entrypoints(cmd, install, shortcut, _create_alias=create_alias):

tests/test_alias.py

@@ -216,3 +216,42 @@ def fake_link(x, y):
         assert_log.end_of_log(),
     )
 
+
+def test_parse_entrypoint_line():
+    for line, expect in [
+        ("", (None, None, None)),
+        ("# comment", (None, None, None)),
+        ("name-only", (None, None, None)),
+        ("name=value", (None, None, None)),
+        ("name=mod:func", ("name", "mod", "func")),
+        ("name=mod:func#comment", ("name", "mod", "func")),
+        (" name = mod : func ", ("name", "mod", "func")),
+        ("name=mod:func[extra]", ("name", "mod", "func")),
+        ("name=mod:func [extra]", ("name", "mod", "func")),
+    ]:
+        assert expect == AU._parse_entrypoint_line(line)
+
+
+def test_scan_entrypoints(tmp_path):
+    site = tmp_path / "site"
+    A = site / "a.dist-info"
+    B = site / "b.dist-info"
+    A.mkdir(exist_ok=True, parents=True)
+    B.mkdir(exist_ok=True, parents=True)
+    (A / "entry_points.txt").write_text("""# Test entries
+[console_scripts]
+a_cmd = a:main
+a2_cmd = a:main2 [spam]
+
+[gui_scripts]
+aw_cmd = a:main
+""")
+    actual = list(AU._scan_one(site))
+    assert [a[0]["name"] for a in actual] == [
+        "a_cmd", "a2_cmd", "aw_cmd"
+    ]
+    assert [a[0]["windowed"] for a in actual] == [0, 0, 1]
+    assert [a[1].rpartition("; ")[2] for a in actual] == [
+        "sys.exit(main())", "sys.exit(main2())", "sys.exit(main())"
+    ]
+