Skip to content

Commit 9568e95

Browse files
committed
Just disable the extension in MSI
1 parent 57c7cfb commit 9568e95

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

src/pymanager/msi.wxs

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
<Property Id="ARPNOMODIFY" Value="1" />
1717
<Property Id="DISABLEADVTSHORTCUTS" Value="1" />
1818

19-
<util:QueryNativeMachine />
20-
2119
<StandardDirectory Id="ProgramFiles64Folder">
2220
<Directory Id="INSTALLFOLDER" Name="PyManager">
2321
<Directory Id="RUNTIME" Name="runtime" />
@@ -43,14 +41,21 @@
4341
<File Source="pyw.exe" Name="pyw.exe" />
4442
<File Source="pymanager.json" />
4543

46-
<File Source="pyshellext.exe">
47-
<Class Id="{C7E29CB0-9691-4DE8-B72B-6719DDC0B4A1}" Advertise="no"
48-
Context="LocalServer32" ThreadingModel="both" />
49-
</File>
50-
5144
<File Source="vcruntime140.dll" />
5245
<File Source="vcruntime140_1.dll" />
5346

47+
<!--
48+
When installed via MSIX, this extension must be out of proc.
49+
Apparently, when installed via MSI, it must be in proc. Which means we'd
50+
need to compile DLLs for each platform just for the MSI, as well as the
51+
EXE that we use for regular installs.
52+
Right now, not worth it.
53+
---
54+
<File Source="pyshellext.exe">
55+
<Class Id="{C7E29CB0-9691-4DE8-B72B-6719DDC0B4A1}" Advertise="no" Context="LocalServer32" />
56+
</File>
57+
-->
58+
5459
<File Source="version.txt" />
5560
<Environment Id="PATH" Action="set" Name="PATH" Part="last" System="yes" Value="[INSTALLFOLDER]" />
5661

0 commit comments

Comments
 (0)