Skip to content

Commit b11b9d6

Browse files
authored
Clarifications to PEP 514-related messages. (#96)
Fixes #84
1 parent 0c2dd81 commit b11b9d6

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/manage/pep514utils.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ def _is_tag_managed(company_key, tag_name, *, creating=False):
170170

171171
# Existing key is almost certainly not valid, so let's rename it,
172172
# warn the user, and then continue.
173-
LOGGER.debug("Key %s appears invalid, so moving it and taking it for this "
174-
"new install", tag_name)
173+
LOGGER.debug("Registry key %s appears invalid, so moving it and taking it "
174+
"for this new install", tag_name)
175175
try:
176176
from _native import reg_rename_key
177177
except ImportError:
@@ -235,10 +235,12 @@ def update_registry(root_name, install, data):
235235
winreg.SetValueEx(tag, "ManagedByPyManager", None, winreg.REG_DWORD, 1)
236236
_update_reg_values(tag, data, install, {"kind", "Key", "ManagedByPyManager"})
237237
else:
238-
LOGGER.warn("A runtime matching %s is already installed, and so "
239-
"the new one has not been registered.", data["Key"])
240-
LOGGER.info("To register the new installation, remove the existing "
241-
"runtime and then run 'py install --refresh'",)
238+
LOGGER.warn("An existing runtime is registered at %s in the registry, "
239+
"and so the new one has not been registered.", data["Key"])
240+
LOGGER.info("This may prevent some other applications from detecting "
241+
"the new installation, although 'py -V:...' will work. "
242+
"To register the new installation, remove the existing "
243+
"runtime and then run 'py install --refresh'")
242244

243245

244246
def cleanup_registry(root_name, keep):
@@ -350,8 +352,8 @@ def _get_unmanaged_installs(root):
350352
try:
351353
yield _read_one_unmanaged_install(company_name, tag_name, is_core, tag)
352354
except Exception:
353-
LOGGER.debug("Failed to read %s\\%s registration", company_name, tag_name)
354-
LOGGER.debug("ERROR", exc_info=True)
355+
LOGGER.debug("Failed to read %s\\%s registration",
356+
company_name, tag_name, exc_info=True)
355357

356358

357359
def _get_store_installs():

0 commit comments

Comments
 (0)