Fix calls

Author: zooba

src/manage/aliasutils.py

@@ -50,7 +50,8 @@ def create_alias(cmd, install, alias, target, aliases_written, *, script_code=No
     p = cmd.global_dir / alias["name"]
     if not p.match("*.exe"):
         p = p.with_name(p.name + ".exe")
-    target = Path(target)
+    if not isinstance(target, Path):
+        target = Path(target)
     ensure_tree(p)
     launcher = cmd.launcher_exe
     if alias.get("windowed"):

src/manage/install_command.py

@@ -274,6 +274,7 @@ def update_all_shortcuts(cmd, *, _create_alias=None, _cleanup_alias=None):
         from .aliasutils import cleanup_alias as _cleanup_alias
 
     LOGGER.debug("Updating global shortcuts")
+    aliases_written = cmd.scratch["aliasutils.create_alias.aliases_written"] = set()
     shortcut_written = {}
     for i in cmd.get_installs():
         if cmd.global_dir:
@@ -294,7 +295,7 @@ def update_all_shortcuts(cmd, *, _create_alias=None, _cleanup_alias=None):
                 if not target.is_file():
                     LOGGER.warn("Skipping alias '%s' because target '%s' does not exist", a["name"], a["target"])
                     continue
-                _create_alias(cmd, i, a, target)
+                _create_alias(cmd, i, a, target, aliases_written)
 
         for s in i.get("shortcuts", ()):
             if cmd.enable_shortcut_kinds and s["kind"] not in cmd.enable_shortcut_kinds:

tests/test_install_command.py

@@ -206,4 +206,5 @@ def create_alias(*a):
         assert sorted(w[2]["name"] for w in written) == ["python3.exe", "pythonw3.exe"]
     # Ensure we still only have the two targets
     assert set(w[3].name for w in written) == {"p.exe", "pw.exe"}
-
+    # Ensure we got an empty set passed in each time
+    assert [w[4] for w in written] == [set()] * len(written)