Clean unused imports and other small code details

Author: pablogsal

pyperformance/_benchmark_selections.py

@@ -5,7 +5,7 @@
 ]
 
 
-from . import _utils, _manifest, _benchmark
+from . import _utils, _benchmark
 
 
 def parse_selection(selection, *, op=None):

pyperformance/_manifest.py

@@ -6,7 +6,6 @@
 ]
 
 
-from collections import namedtuple
 import os.path
 
 

pyperformance/_pip.py

@@ -1,7 +1,5 @@
 import os
 import os.path
-import shlex
-import subprocess
 import sys
 
 from . import _utils, _pythoninfo

pyperformance/_utils.py

@@ -25,8 +25,6 @@
 import os.path
 import shlex
 import shutil
-import subprocess
-import sys
 import tempfile
 import urllib.request
 
@@ -84,7 +82,6 @@ def safe_rmtree(path):
 #######################################
 # platform utils
 
-import logging
 import subprocess
 import sys
 
@@ -216,7 +213,8 @@ def parse_selections(selections, parse_entry=None):
     if isinstance(selections, str):
         selections = selections.split(',')
     if parse_entry is None:
-        parse_entry = (lambda o, e: (o, e, None, e))
+        def parse_entry(o, e):
+            return (o, e, None, e)
 
     for entry in selections:
         entry = entry.strip()

pyperformance/cli.py

@@ -226,7 +226,8 @@ def _select_benchmarks(raw, manifest):
 
     # Get the raw list of benchmarks.
     entries = raw.lower()
-    parse_entry = (lambda o, s: _benchmark_selections.parse_selection(s, op=o))
+    def parse_entry(o, s):
+        return _benchmark_selections.parse_selection(s, op=o)
     parsed = _utils.parse_selections(entries, parse_entry)
     parsed_infos = list(parsed)
 

pyperformance/commands.py

@@ -51,7 +51,7 @@ def cmd_list_groups(manifest, *, showtags=True):
 
 
 def cmd_venv_create(options, root, python, benchmarks):
-    from . import _pythoninfo, _venv
+    from . import _venv
     from .venv import Requirements, VenvForBenchmarks
 
     if _venv.venv_exists(root):
@@ -73,7 +73,7 @@ def cmd_venv_create(options, root, python, benchmarks):
 
 
 def cmd_venv_recreate(options, root, python, benchmarks):
-    from . import _pythoninfo, _venv, _utils
+    from . import _venv, _utils
     from .venv import Requirements, VenvForBenchmarks
 
     requirements = Requirements.from_benchmarks(benchmarks)

pyperformance/compare.py

@@ -1,7 +1,6 @@
 import csv
 import os.path
 import math
-import sys
 
 import pyperf
 import statistics

pyperformance/data-files/benchmarks/bm_docutils/run_benchmark.py

@@ -4,7 +4,6 @@
 
 import contextlib
 from pathlib import Path
-import time
 
 import docutils
 from docutils import core

pyperformance/tests/__init__.py

@@ -68,9 +68,11 @@ def create_venv(root=None, python=sys.executable, *, verbose=False):
     if not root:
         tmpdir = tempfile.mkdtemp()
         root = os.path.join(tmpdir, 'venv')
-        cleanup = (lambda: shutil.rmtree(tmpdir))
+        def cleanup():
+            return shutil.rmtree(tmpdir)
     else:
-        cleanup = (lambda: None)
+        def cleanup():
+            return None
     run_cmd(
         python or sys.executable, '-m', 'venv', root,
         capture=not verbose,
@@ -160,9 +162,8 @@ def addClassCleanup(cls, cleanup):
 NON_WINDOWS_ONLY = unittest.skipIf(os.name == 'nt', 'skipping Windows')
 
 # XXX Provide a way to run slow tests.
-SLOW = (lambda f:
-            unittest.skip('way too slow')(
-                mark('slow', f)))
+def SLOW(f):
+    return unittest.skip('way too slow')(mark('slow', f))
 
 
 class Functional(Compat):

pyperformance/tests/data/bm_local_wheel/run_benchmark.py

@@ -3,7 +3,6 @@
 """
 
 import pyperf
-from this_is import en_us
 
 
 def bench():