Fix sqlglot normalize benchmark #378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you provide more detail on what this is fixing? |
Contributor
Author
|
The function "normalize.normalize" change the content of "conjunction" string to its normalized form. So, from the second iteration, "conjunction" is the normalized form of the original string. |
Contributor
|
Thanks for the explanation. That makes sense. Since this will change the behavior of the benchmark, it will no longer be comparable to previously collected data from this benchmark. In these situations, what we normally do is create a new benchmark -- e.g. |
Conjunction string is changing in every iteration. Now, conjunction string is created for every iteration. Update sqlglot to V2 Fix test cases for sqlglot v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conjunction string is changing in every iteration. Now, conjunction string is created for every iteration.