Skip to content

Fix missing comma in _benchmark.__all__ #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

Fix missing comma in _benchmark.__all__ #404

merged 1 commit into from
Sep 1, 2025

Conversation

@maurycy
Copy link
Contributor

@maurycy maurycy commented Sep 1, 2025

No description provided.

@maurycy
Copy link
Contributor Author

maurycy commented Sep 1, 2025

I noticed this while familiarizing with the code but uvx ruff check catches it as well:

23:38:27.527666000PM CEST maurycy@gimel /Users/maurycy/src/pyperformance % uvx ruff check pyperformance/_benchmark.py
F822 Undefined name `Benchmarkcheck_name` in `__all__`
 --> pyperformance/_benchmark.py:4:5
  |
2 |   __all__ = [
3 |       'BenchmarkSpec',
4 | /     'Benchmark'
5 | |     'check_name',
  | |________________^
6 |       'parse_benchmark',
7 |   ]
  |

Maybe it's a good idea to run it over the whole project?

@maurycy maurycy mentioned this pull request Sep 1, 2025
Merged
@AA-Turner AA-Turner merged commit 7b33ce2 into python:main Sep 1, 2025
19 checks passed
@AA-Turner
Copy link
Member

AA-Turner commented Sep 1, 2025

Rather apposite that this was PR #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maurycy @AA-Turner