chore: apply code review

Author: JacobCoffee

docker-compose.yml

@@ -1,19 +1,6 @@
 version: "3.9"
 
 services:
-#   postgres:
-#     image: postgres:10-bullseye
-#     ports:
-#       - "5433:5432"
-#     environment:
-#       POSTGRES_USER: pythondotorg
-#       POSTGRES_PASSWORD: pythondotorg
-#       POSTGRES_DB: pythondotorg
-#       POSTGRES_HOST_AUTH_METHOD: trust  # never do this in production!
-#     healthcheck:
-#       test: ["CMD", "pg_isready", "-U", "pythondotorg", "-d", "pythondotorg"]
-#       interval: 1s
-
   postgres:
     image: postgres:12-bullseye  # required for 4.2 upgrades
     ports:

events/tests/test_importer.py

@@ -2,7 +2,6 @@
 
 from django.test import TestCase
 from django.utils.timezone import datetime, make_aware
-from django.utils.html import strip_tags
 
 from events.importer import ICSImporter
 from events.models import Calendar, Event

users/tests/test_forms.py

@@ -50,9 +50,8 @@ def test_duplicate_username(self):
         self.assertIn('username', form.errors)
 
     def test_duplicate_email(self):
-        from django.http import HttpRequest
         User.objects.create_user('test1', '[email protected]', 'testpass')
-        request = HttpRequest()
+        request = RequestFactory().get('/')
 
         form = SignupForm(data={
             'username': 'username2',

users/tests/test_views.py

@@ -2,7 +2,7 @@
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.urls import reverse
-from django.test import TestCase
+from django.test import TestCase, override_settings
 
 from sponsors.forms import SponsorUpdateForm, SponsorRequiredAssetsForm
 from sponsors.models import Sponsorship, RequiredTextAssetConfiguration, SponsorBenefit
@@ -228,8 +228,8 @@ def test_user_new_account(self):
             'password2': 'password',
         })
 
+    @override_settings(ACCOUNT_PREVENT_ENUMERATION=False)
     def test_user_duplicate_username_email(self):
-        settings.ACCOUNT_PREVENT_ENUMERATION = False
         post_data = {
             'username': 'thisusernamedoesntexist',
             'email': '[email protected]',