Enable admin staff to add benefits to Sponsorship via admin (#1942)

* Remove restriction to prevent from adding benefits

* Make sure sponsors benefit inline form also updates the related information

* Force cfg to be at sponsorship level

* assign benefit_internal_value from benefit if not supplied

Co-authored-by: Ee Durbin <[email protected]>

Author: berinhard

sponsors/admin.py

@@ -166,7 +166,6 @@ class SponsorBenefitInline(admin.TabularInline):
     form = SponsorBenefitAdminInlineForm
     fields = ["sponsorship_benefit", "benefit_internal_value"]
     extra = 0
-    max_num = 0
 
     def has_add_permission(self, request, obj=None):
         has_add_permission = super().has_add_permission(request, obj=obj)

sponsors/forms.py

@@ -398,8 +398,12 @@ def save(self, commit=True):
         else:
             self.instance.refresh_from_db()
 
-        self.instance.benefit_internal_value = value
+        self.instance.benefit_internal_value = benefit.internal_value
+        if value:
+            self.instance.benefit_internal_value = value
+        updated_sponsorship_benefit = False
         if benefit.pk != self.instance.sponsorship_benefit_id:
+            updated_sponsorship_benefit = True
             self.instance.sponsorship_benefit = benefit
             self.instance.name = benefit.name
             self.instance.description = benefit.description
@@ -408,6 +412,11 @@ def save(self, commit=True):
         if commit:
             self.instance.save()
 
+            if updated_sponsorship_benefit:
+                self.instance.features.all().delete()
+                for feature_config in benefit.features_config.all():
+                    feature_config.create_benefit_feature(self.instance)
+
         return self.instance
 
 

sponsors/tests/test_forms.py

@@ -16,7 +16,7 @@
     SendSponsorshipNotificationForm, SponsorRequiredAssetsForm,
 )
 from sponsors.models import SponsorshipBenefit, SponsorContact, RequiredTextAssetConfiguration, \
-    RequiredImgAssetConfiguration, ImgAsset
+    RequiredImgAssetConfiguration, ImgAsset, RequiredTextAsset
 from .utils import get_static_image_file_as_upload
 from ..models.enums import AssetsRelatedTo
 
@@ -473,7 +473,6 @@ def test_do_not_update_sponsorship_if_it_doesn_change(self):
             sponsorship=self.sponsorship,
             sponsorship_benefit=self.benefit,
         )
-        new_benefit = baker.make(SponsorshipBenefit)
 
         form = SponsorBenefitAdminInlineForm(data=self.data, instance=sponsor_benefit)
         self.assertTrue(form.is_valid(), form.errors)
@@ -488,6 +487,29 @@ def test_do_not_update_sponsorship_if_it_doesn_change(self):
         self.assertNotEqual(sponsor_benefit.name, "new name")
         self.assertEqual(sponsor_benefit.benefit_internal_value, 200)
 
+    def test_update_existing_benefit_features(self):
+        sponsor_benefit = baker.make(
+            SponsorBenefit,
+            sponsorship=self.sponsorship,
+            sponsorship_benefit=self.benefit,
+        )
+        # existing benefit depends on logo
+        baker.make_recipe('sponsors.tests.logo_at_download_feature', sponsor_benefit=sponsor_benefit)
+
+        # new benefit requires text instead of logo
+        new_benefit = baker.make(SponsorshipBenefit)
+        baker.make(RequiredTextAssetConfiguration, benefit=new_benefit, internal_name='foo',
+                   related_to=AssetsRelatedTo.SPONSORSHIP.value)
+        self.data["sponsorship_benefit"] = new_benefit.pk
+
+        form = SponsorBenefitAdminInlineForm(data=self.data, instance=sponsor_benefit)
+        self.assertTrue(form.is_valid(), form.errors)
+        form.save()
+        sponsor_benefit.refresh_from_db()
+
+        self.assertEqual(sponsor_benefit.features.count(), 1)
+        self.assertIsInstance(sponsor_benefit.features.get(), RequiredTextAsset)
+
 
 class SponsorshipsFormTestCase(TestCase):