Sort downloads table by version

Author: hugovk

downloads/tests/test_views.py

@@ -56,6 +56,21 @@ def test_download(self):
         response = self.client.get(url)
         self.assertEqual(response.status_code, 200)
 
+    def test_download_releases_ordered_by_version(self):
+        url = reverse("download:download")
+        response = self.client.get(url)
+        releases = response.context["releases"]
+        self.assertEqual(
+            releases,
+            [
+                self.python_3,
+                self.python_3_10_18,
+                self.python_3_8_20,
+                self.python_3_8_19,
+                self.release_275,
+            ],
+        )
+
     def test_latest_redirects(self):
         latest_python2 = Release.objects.released().python2().latest()
         url = reverse('download:download_latest_python2')

downloads/views.py

@@ -124,8 +124,17 @@ def get_context_data(self, **kwargs):
                 data['pymanager'] = latest_pymanager.download_file_for_os(o.slug)
             python_files.append(data)
 
+        def version_key(release: Release) -> tuple[int, ...]:
+            try:
+                return tuple(int(x) for x in release.get_version().split("."))
+            except ValueError:
+                return (0,)
+
+        releases = list(Release.objects.downloads())
+        releases.sort(key=version_key, reverse=True)
+
         context.update({
-            'releases': Release.objects.downloads(),
+            'releases': releases,
             'latest_python2': latest_python2,
             'latest_python3': latest_python3,
             'python_files': python_files,

templates/downloads/index.html

@@ -50,7 +50,7 @@ <h1 class="call-to-action">Download the latest version of Python</h1>
                 <div class="row active-release-list-widget">
                     {% render_active_banner %}
 
-                    <h2 class="widget-title">Active Python Releases</h2>
+                    <h2 class="widget-title">Active Python releases</h2>
                     <p class="success-quote"><a href="https://devguide.python.org/versions/#versions">For more information visit the Python Developer's Guide</a>.</p>
 
                     {% box 'downloads-active-releases' %}
@@ -74,7 +74,7 @@ <h2 class="widget-title">Looking for a specific release?</h2>
                             <span class="release-number"><a href="{{ r.get_absolute_url }}">{{ r.name }}</a></span>
                             <span class="release-date">{{ r.release_date|date }}</span>
                             <span class="release-download"><a href="{{ r.get_absolute_url }}"><span aria-hidden="true" class="icon-download"></span> Download</a></span>
-                            <span class="release-enhancements"><a href="{{ r.release_notes_url }}">Release Notes</a></span>
+                            <span class="release-enhancements"><a href="{{ r.release_notes_url }}">Release notes</a></span>
                         </li>
                         {% endfor %}
                     </ol>