Skip to content

Conversation

@srittau
Copy link
Collaborator

@srittau srittau commented May 25, 2025

No description provided.

@srittau srittau linked an issue May 25, 2025 that may be closed by this pull request
@srittau
Copy link
Collaborator Author

srittau commented May 25, 2025

Um, pre-commit makes "interesting" (and clearly wrong) things in c3df9f6.

@JelleZijlstra
Copy link
Member

pre-commit makes "interesting" (and clearly wrong) things

It probably doesn't recognize typing_extensions.TypeAlias as marking a type alias. You probably need # noqa: PYI015 (https://docs.astral.sh/ruff/rules/assignment-default-in-stub/)

@AlexWaygood
Copy link
Member

pre-commit makes "interesting" (and clearly wrong) things

It probably doesn't recognize typing_extensions.TypeAlias as marking a type alias. You probably need # noqa: PYI015 (docs.astral.sh/ruff/rules/assignment-default-in-stub)

I think the reason it failed to recognize TypeAlias as being TypeAlias here is because we're actually editing typing_extensions.pyi itself. If we'd imported it from typing_extensions (or typing), it would have recognized it, I think.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 07c09a4 into python:main May 25, 2025
101 checks passed
@srittau srittau deleted the fix-extensions branch May 25, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily tests failed on Sun May 25 2025

3 participants