Skip to content

Conversation

donBarbos
Copy link
Contributor

Closes: #14496

This comment has been minimized.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/util/nodes.py:686: error: Unused "type: ignore" comment  [unused-ignore]
+ sphinx/util/nodes.py: note: In function "set_role_source_info":
+ sphinx/util/nodes.py:687:30: error: Incompatible types in assignment (expression has type "str | PathLike[str] | None", variable has type "str | None")  [assignment]
+ sphinx/util/docutils.py:681: error: Unused "type: ignore" comment  [unused-ignore]
+ sphinx/util/docutils.py: note: In member "get_source_info" of class "SphinxRole":
+ sphinx/util/docutils.py:681:16: error: Incompatible return value type (got "tuple[str | PathLike[str] | None, int | None]", expected "tuple[str, int]")  [return-value]
+ sphinx/util/docutils.py:681:16: note: Error code "return-value" not covered by "type: ignore" comment
+ sphinx/util/docutils.py: note: At top level:
- sphinx/util/docutils.py: note: In function "_get_settings":
- sphinx/util/docutils.py:914:12: error: Call to untyped function "get_default_values" in typed context  [no-untyped-call]
- sphinx/util/docutils.py:914:12: note: Error code "no-untyped-call" not covered by "type: ignore" comment
+ sphinx/ext/autodoc/directive.py:108: error: Unused "type: ignore" comment  [unused-ignore]
+ sphinx/ext/autodoc/directive.py: note: In member "run" of class "AutodocDirective":
+ sphinx/ext/autodoc/directive.py:139:53: error: Argument 4 to "DocumenterBridge" has incompatible type "int | None"; expected "int"  [arg-type]
+ sphinx/builders/__init__.py: note: In member "write_doctree" of class "Builder":
+ sphinx/builders/__init__.py:698:48: error: Incompatible types in assignment (expression has type "None", variable has type "DependencyList")  [assignment]
+ sphinx/ext/autosummary/__init__.py:64:1: error: Module "docutils.parsers.rst.states" does not explicitly export attribute "Struct"  [attr-defined]

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 21b9118 into python:main Aug 13, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants