Remove duplicate get_external_apt_dependencies.py and re-standardize CI package install logs
#14533
+26
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e CI package install logs
srittau
requested changes
Aug 8, 2025
|
Sorry for the slow response, thanks for catching it wasn't deduped. As for sorting, I left it to the script itself rather than the ts_utils lib. This reflects how |
srittau
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @srittau I noticed that the script you added in #13976 is actually just a duplicate of
get_stubtest_system_requirements.pybut that only works on linux. Calling the existingget_stubtest_system_requirements.pyinstead would've worked the same.I also:
$DEPENDENCIESvs$PACKAGESas a variable name in the CI scripts to make more of the scripts identical.