grpcio: improve server interceptor typing #14785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerInterceptorandGenericRpcHandlershould not be generic over request/response themselves, but rather should have generic methods:ServerInterceptor: a given instance of this should be able to intercept any call, and so should have a generic method over all request/continuation types rather than the instance being specialized itselfGenericRpcHandler(andServiceRpcHandler): this is "An implementation of arbitrarily many RPC methods" and has aservicemethod that takes a parameter describing the method to handle, but that parameter dictates the request/response types. The instance of theGenericRpcHandleritself does not know about the request/response types. In theory this could be described using dependent types, but since this is Python the best we can do is have theservicemethod return a type withAnys and allow the caller to cast laterRelated: #14641