tkinter: Fix return type of winfo_children() #14791
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
winfo_children()method returns a list of the child widgets of a widget. Previously I thought this could never beToplevelwidgets, but that is wrong: they can in fact be anything excepttkinter.Tk.Tkcan never be the child of another widget, because it is a special widget and each instance ofTkis internally a whole new Tcl interpreter.Ideally, the type of this would be
Misc & ~Tk; that is, any widget except Tk. But because&and~operators on types don't exist yet, the best we can do isWidget | Toplevel. Misleadingly,Widgetin tkinter means any widget exceptTkorToplevel, andMiscmeans any widget.