rename overloads_invalid to overloads_definitions

Author: carljm

conformance/results/mypy/overloads_definitions.toml

@@ -0,0 +1,47 @@
+conformant = "Partial"
+conformance_automated = "Fail"
+notes = """
+Does not allow an overload with no implementation in an abstract base class.
+"""
+errors_diff = """
+Line 49: Unexpected errors ['overloads_definitions.py:49: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]']
+Line 202: Unexpected errors ['overloads_definitions.py:202: error: Signature of "good_override" incompatible with supertype "Base"  [override]']
+"""
+output = """
+overloads_definitions.py:14: error: Single overload definition, multiple required  [misc]
+overloads_definitions.py:26: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
+overloads_definitions.py:49: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
+overloads_definitions.py:63: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
+overloads_definitions.py:78: error: Overload does not consistently use the "@staticmethod" decorator on all function signatures.  [misc]
+overloads_definitions.py:88: error: Overloaded function implementation does not accept all possible arguments of signature 1  [misc]
+overloads_definitions.py:88: error: Overloaded function implementation does not accept all possible arguments of signature 2  [misc]
+overloads_definitions.py:91: error: Overload does not consistently use the "@classmethod" decorator on all function signatures.  [misc]
+overloads_definitions.py:133: error: @final should be applied only to overload implementation  [misc]
+overloads_definitions.py:148: error: @final should be applied only to overload implementation  [misc]
+overloads_definitions.py:176: error: Cannot override final attribute "final_method" (previously declared in base class "Base")  [misc]
+overloads_definitions.py:176: error: Signature of "final_method" incompatible with supertype "Base"  [override]
+overloads_definitions.py:176: note:      Superclass:
+overloads_definitions.py:176: note:          @overload
+overloads_definitions.py:176: note:          def final_method(self, x: int) -> int
+overloads_definitions.py:176: note:          @overload
+overloads_definitions.py:176: note:          def final_method(self, x: str) -> str
+overloads_definitions.py:176: note:      Subclass:
+overloads_definitions.py:176: note:          def final_method(self, x: int | str) -> int | str
+overloads_definitions.py:183: error: Method "bad_override" is marked as an override, but no base method was found with this name  [misc]
+overloads_definitions.py:202: error: Signature of "good_override" incompatible with supertype "Base"  [override]
+overloads_definitions.py:202: note:      Superclass:
+overloads_definitions.py:202: note:          def good_override(self, x: int | str) -> int | str
+overloads_definitions.py:202: note:      Subclass:
+overloads_definitions.py:202: note:          @overload
+overloads_definitions.py:202: note:          def good_override(self, x: int) -> int
+overloads_definitions.py:202: note:          @overload
+overloads_definitions.py:202: note:          def good_override(self, x: str) -> str
+overloads_definitions.py:217: error: Signature of "to_override" incompatible with supertype "Base"  [override]
+overloads_definitions.py:217: note:      Superclass:
+overloads_definitions.py:217: note:          def to_override(self, x: int | str) -> int | str
+overloads_definitions.py:217: note:      Subclass:
+overloads_definitions.py:217: note:          @overload
+overloads_definitions.py:217: note:          def to_override(self, x: int) -> int
+overloads_definitions.py:217: note:          @overload
+overloads_definitions.py:217: note:          def to_override(self, x: str) -> str
+"""

conformance/results/mypy/overloads_invalid.toml

@@ -0,0 +1,32 @@
+conformant = "Partial"
+conformance_automated = "Fail"
+notes = """
+Does not allow an overload with no implementation in a Protocol or an abstract base class.
+Expects @final/@override on all overloads and implementation, instead of implementation only.
+"""
+errors_diff = """
+Line 217: Expected 1 errors
+Lines 148, 150: Expected error (tag 'invalid_final_2')
+Line 40: Unexpected errors ['overloads_definitions.py:40:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.']
+Line 51: Unexpected errors ['overloads_definitions.py:51:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.']
+Line 128: Unexpected errors ['overloads_definitions.py:128:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 211: Unexpected errors ['overloads_definitions.py:211:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+"""
+output = """
+overloads_definitions.py:15:0 Incompatible overload [43]: At least two overload signatures must be present.
+overloads_definitions.py:27:0 Missing overload implementation [42]: Overloaded function `func2` must have an implementation.
+overloads_definitions.py:40:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.
+overloads_definitions.py:51:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.
+overloads_definitions.py:64:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.not_abstract` must have an implementation.
+overloads_definitions.py:80:4 Incompatible overload [43]: The implementation of `C.func5` does not accept all possible arguments of overload defined on line `80`.
+overloads_definitions.py:85:4 Incompatible overload [43]: The implementation of `C.func5` does not accept all possible arguments of overload defined on line `85`.
+overloads_definitions.py:88:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions.py:97:4 Incompatible overload [43]: The implementation of `C.func6` does not accept all possible arguments of overload defined on line `97`.
+overloads_definitions.py:97:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions.py:128:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions.py:139:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions.py:176:4 Invalid override [40]: `overloads_definitions.Child.final_method` cannot override final method defined in `Base`.
+overloads_definitions.py:192:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions.py:192:4 Invalid override [40]: `overloads_definitions.Child.bad_override` is decorated with @override, but no method of the same name exists in superclasses of `Child`.
+overloads_definitions.py:211:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+"""

conformance/results/pyre/overloads_definitions.toml

@@ -0,0 +1,36 @@
+conformant = "Partial"
+notes = """
+Allows @final/@override on all overloads and implementation; should be implementation-only.
+"""
+conformance_automated = "Fail"
+errors_diff = """
+Line 217: Expected 1 errors
+Lines 148, 150: Expected error (tag 'invalid_final_2')
+"""
+output = """
+overloads_definitions.py:15:5 - error: "func1" is marked as overload, but additional overloads are missing (reportInconsistentOverload)
+overloads_definitions.py:27:5 - error: "func2" is marked as overload, but no implementation is provided (reportNoOverloadImplementation)
+overloads_definitions.py:64:9 - error: "not_abstract" is marked as overload, but no implementation is provided (reportNoOverloadImplementation)
+overloads_definitions.py:80:9 - error: Overloads for "func5" use @staticmethod inconsistently (reportInconsistentOverload)
+overloads_definitions.py:88:9 - error: Overloaded implementation is not consistent with signature of overload 1
+  Type "(self: Self@C, x: int | str) -> (int | str)" is not assignable to type "(x: int) -> int"
+    Parameter name mismatch: "x" versus "self"
+    Parameter 1: type "int" is incompatible with type "Self@C"
+      Type "int" is not assignable to type "Self@C"
+    Extra parameter "x" (reportInconsistentOverload)
+overloads_definitions.py:88:9 - error: Overloaded implementation is not consistent with signature of overload 2
+  Type "(self: Self@C, x: int | str) -> (int | str)" is not assignable to type "(x: str) -> str"
+    Parameter name mismatch: "x" versus "self"
+    Parameter 1: type "str" is incompatible with type "Self@C"
+      Type "str" is not assignable to type "Self@C"
+    Extra parameter "x" (reportInconsistentOverload)
+overloads_definitions.py:93:9 - error: Overloads for "func6" use @classmethod inconsistently (reportInconsistentOverload)
+overloads_definitions.py:97:15 - warning: Instance methods should take a "self" parameter (reportSelfClsParameterName)
+overloads_definitions.py:135:9 - error: Overload for "invalid_final" is marked @final but implementation is not (reportInconsistentOverload)
+overloads_definitions.py:176:9 - error: Method "final_method" cannot override final method defined in class "Base" (reportIncompatibleMethodOverride)
+overloads_definitions.py:176:9 - error: Method "final_method" overrides class "Base" in an incompatible manner
+  Return type mismatch: base method returns type "int", override returns type "int | str"
+    Type "int | str" is not assignable to type "int"
+      "str" is not assignable to "int" (reportIncompatibleMethodOverride)
+overloads_definitions.py:192:9 - error: Method "bad_override" is marked as override, but no base method of same name is present (reportGeneralTypeIssues)
+"""

conformance/results/pyre/overloads_invalid.toml

@@ -1,2 +1,2 @@
 version = "pyright 1.1.391"
-test_duration = 1.6
+test_duration = 1.5