add tests for signature-transforming decorators

Author: carljm

conformance/results/mypy/version.toml

@@ -1,2 +1,2 @@
 version = "mypy 1.14.1"
-test_duration = 1.7
+test_duration = 1.8

conformance/results/pyre/overloads_consistency.toml

@@ -1,8 +1,18 @@
-conformant = "Pass"
-conformance_automated = "Pass"
+conformant = "Partial"
+notes = """
+Does not apply decorator transforms before checking overload consistency.
+"""
+conformance_automated = "Fail"
 errors_diff = """
+Line 107: Unexpected errors ['overloads_consistency.py:107:0 Incompatible overload [43]: The return type of overloaded function `decorated` (`None`) is incompatible with the return type of the implementation (`bytes`).', 'overloads_consistency.py:107:0 Incompatible overload [43]: The implementation of `decorated` does not accept all possible arguments of overload defined on line `107`.']
+Line 111: Unexpected errors ['overloads_consistency.py:111:0 Incompatible overload [43]: The return type of overloaded function `decorated` (`str`) is incompatible with the return type of the implementation (`bytes`).', 'overloads_consistency.py:111:0 Incompatible overload [43]: The implementation of `decorated` does not accept all possible arguments of overload defined on line `111`.', 'overloads_consistency.py:111:0 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
 """
 output = """
 overloads_consistency.py:24:0 Incompatible overload [43]: The return type of overloaded function `return_type` (`str`) is incompatible with the return type of the implementation (`int`).
 overloads_consistency.py:40:0 Incompatible overload [43]: The implementation of `parameter_type` does not accept all possible arguments of overload defined on line `40`.
+overloads_consistency.py:107:0 Incompatible overload [43]: The return type of overloaded function `decorated` (`None`) is incompatible with the return type of the implementation (`bytes`).
+overloads_consistency.py:107:0 Incompatible overload [43]: The implementation of `decorated` does not accept all possible arguments of overload defined on line `107`.
+overloads_consistency.py:111:0 Incompatible overload [43]: The return type of overloaded function `decorated` (`str`) is incompatible with the return type of the implementation (`bytes`).
+overloads_consistency.py:111:0 Incompatible overload [43]: The implementation of `decorated` does not accept all possible arguments of overload defined on line `111`.
+overloads_consistency.py:111:0 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
 """

conformance/results/pyre/version.toml

@@ -1,2 +1,2 @@
 version = "pyre 0.9.23"
-test_duration = 6.5
+test_duration = 6.0

conformance/results/pyright/version.toml

@@ -1,2 +1,2 @@
 version = "pyright 1.1.391"
-test_duration = 1.5
+test_duration = 1.7

conformance/results/pytype/overloads_consistency.toml

@@ -10,6 +10,8 @@ Line 28: Unexpected errors ['overloads_consistency.py:28:12: \\x1b[1m\\x1b[31mer
 Line 44: Unexpected errors ['overloads_consistency.py:44:12: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in parameter_type: bad return type [bad-return-type]']
 Line 73: Unexpected errors ['overloads_consistency.py:73:12: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in returns_coroutine: bad return type [bad-return-type]']
 Line 88: Unexpected errors ['overloads_consistency.py:88:5: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in returns_coroutine_2: bad return type [bad-return-type]', 'overloads_consistency.py:88:5: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in returns_coroutine_2: bad return type [bad-return-type]']
+Line 107: Unexpected errors ['overloads_consistency.py:107:1: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in <module>: Function decorated expects 0 arg(s), got 1 [wrong-arg-count]']
+Line 115: Unexpected errors ["overloads_consistency.py:115:1: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in <module>: Missing parameter 'z' in call to function decorated [missing-parameter]"]
 """
 output = """
 overloads_consistency.py:28:12: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in return_type: bad return type [bad-return-type]
@@ -37,4 +39,18 @@ overloads_consistency.py:88:5: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in r
     return _wrapped(x)
     \u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
 
+overloads_consistency.py:107:1: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in <module>: Function decorated expects 0 arg(s), got 1 [wrong-arg-count]
+
+def decorated() -> None:
+\u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+    ...
+\u001b[1m\u001b[31m~~~~~~~\u001b[39m\u001b[0m
+
+overloads_consistency.py:115:1: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in <module>: Missing parameter 'z' in call to function decorated [missing-parameter]
+
+def decorated(y: bytes, z: bytes) -> bytes:
+\u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+    return b""
+\u001b[1m\u001b[31m~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+
 """

conformance/results/pytype/version.toml

@@ -1,2 +1,2 @@
 version = "pytype 2024.10.11"
-test_duration = 30.1
+test_duration = 31.1

conformance/results/results.html

@@ -159,16 +159,16 @@ <h3>Python Type System Conformance Test Results</h3>
         <div class="table_container"><table><tbody>
 <tr><th class="col1">&nbsp;</th>
 <th class='tc-header'><div class='tc-name'>mypy 1.14.1</div>
-<div class='tc-time'>1.7sec</div>
+<div class='tc-time'>1.8sec</div>
 </th>
 <th class='tc-header'><div class='tc-name'>pyright 1.1.391</div>
-<div class='tc-time'>1.5sec</div>
+<div class='tc-time'>1.7sec</div>
 </th>
 <th class='tc-header'><div class='tc-name'>pyre 0.9.23</div>
-<div class='tc-time'>6.5sec</div>
+<div class='tc-time'>6.0sec</div>
 </th>
 <th class='tc-header'><div class='tc-name'>pytype 2024.10.11</div>
-<div class='tc-time'>30.1sec</div>
+<div class='tc-time'>31.1sec</div>
 </th>
 </tr>
 <tr><th class="column" colspan="5">

conformance/tests/overloads_consistency.py

@@ -2,7 +2,7 @@
 Tests consistency of overloads with implementation.
 """
 
-from typing import Coroutine, overload
+from typing import Callable, Coroutine, overload
 
 # > If an overload implementation is defined, type checkers should validate
 # > that it is consistent with all of its associated overload signatures.
@@ -89,3 +89,29 @@ def returns_coroutine_2(x: int | str) -> Coroutine[None, None, int | str]:
 
 async def _wrapped(x: int | str) -> int | str:
     return 2
+
+# Decorator transforms are applied before checking overload consistency:
+
+def _deco_1(f: Callable) -> Callable[[int], int]:
+    def wrapped(_x: int, /) -> int:
+        return 1
+    return wrapped
+
+def _deco_2(f: Callable) -> Callable[[int | str], int | str]:
+    def wrapped(_x: int | str, /) -> int | str:
+        return 1
+    return wrapped
+
+@overload
+@_deco_1
+def decorated() -> None:
+    ...
+
+@overload
+def decorated(x: str, /) -> str:
+    ...
+
+@_deco_2
+def decorated(y: bytes, z: bytes) -> bytes:
+    return b""
+