Skip to content

Commit 85ca00b

Browse files
committed
Conformance - fix saving toml results file in non-unicode
Noticed that pyright is giving unicode output that on Windows is leading to issues generating reports later. Saving this output explicitly as unicode resolves the issue. ```python Generating summary report Traceback (most recent call last): File "\typing\conformance\src\main.py", line 260, in <module> main() File "\typing\conformance\src\main.py", line 256, in main generate_summary(root_dir) File "\typing\conformance\src\reporting.py", line 19, in generate_summary summary = template.replace("{{summary}}", generate_summary_html(root_dir)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "\typing\conformance\src\reporting.py", line 87, in generate_summary_html results = tomli.load(f) ^^^^^^^^^^^^^ File "src\tomli\_parser.py", line 134, in load UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa0 in position 110: invalid start byte ```
1 parent 0b9fed8 commit 85ca00b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

conformance/src/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def update_output_for_test(
197197
notes = "\n" + notes
198198
existing_results["notes"] = tomlkit.string(notes, multiline=True)
199199
results_file.parent.mkdir(parents=True, exist_ok=True)
200-
with open(results_file, "w") as f:
200+
with open(results_file, "w", encoding="utf-8") as f:
201201
tomlkit.dump(existing_results, f)
202202

203203

0 commit comments

Comments
 (0)