add test for final with overload

Author: carljm

conformance/results/mypy/overloads_invalid.toml

@@ -4,15 +4,26 @@ notes = """
 Does not allow an overload with no implementation in an abstract base class.
 """
 errors_diff = """
-Line 47: Unexpected errors ['overloads_invalid.py:47: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]']
+Line 49: Unexpected errors ['overloads_invalid.py:49: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]']
 """
 output = """
-overloads_invalid.py:12: error: Single overload definition, multiple required  [misc]
-overloads_invalid.py:24: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
-overloads_invalid.py:47: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
-overloads_invalid.py:61: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
-overloads_invalid.py:76: error: Overload does not consistently use the "@staticmethod" decorator on all function signatures.  [misc]
-overloads_invalid.py:86: error: Overloaded function implementation does not accept all possible arguments of signature 1  [misc]
-overloads_invalid.py:86: error: Overloaded function implementation does not accept all possible arguments of signature 2  [misc]
-overloads_invalid.py:89: error: Overload does not consistently use the "@classmethod" decorator on all function signatures.  [misc]
+overloads_invalid.py:14: error: Single overload definition, multiple required  [misc]
+overloads_invalid.py:26: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
+overloads_invalid.py:49: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
+overloads_invalid.py:63: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]
+overloads_invalid.py:78: error: Overload does not consistently use the "@staticmethod" decorator on all function signatures.  [misc]
+overloads_invalid.py:88: error: Overloaded function implementation does not accept all possible arguments of signature 1  [misc]
+overloads_invalid.py:88: error: Overloaded function implementation does not accept all possible arguments of signature 2  [misc]
+overloads_invalid.py:91: error: Overload does not consistently use the "@classmethod" decorator on all function signatures.  [misc]
+overloads_invalid.py:127: error: @final should be applied only to overload implementation  [misc]
+overloads_invalid.py:139: error: @final should be applied only to overload implementation  [misc]
+overloads_invalid.py:155: error: Cannot override final attribute "final_method" (previously declared in base class "Base")  [misc]
+overloads_invalid.py:155: error: Signature of "final_method" incompatible with supertype "Base"  [override]
+overloads_invalid.py:155: note:      Superclass:
+overloads_invalid.py:155: note:          @overload
+overloads_invalid.py:155: note:          def final_method(self, x: int) -> int
+overloads_invalid.py:155: note:          @overload
+overloads_invalid.py:155: note:          def final_method(self, x: str) -> str
+overloads_invalid.py:155: note:      Subclass:
+overloads_invalid.py:155: note:          def final_method(self, x: int | str) -> int | str
 """

conformance/results/pyre/overloads_invalid.toml

@@ -2,21 +2,26 @@ conformant = "Partial"
 conformance_automated = "Fail"
 notes = """
 Does not allow an overload with no implementation in a Protocol or an abstract base class.
+Expects @final on all overloads and implementation, instead of implementation only.
 """
 errors_diff = """
-Line 38: Unexpected errors ['overloads_invalid.py:38:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.']
-Line 49: Unexpected errors ['overloads_invalid.py:49:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.']
+Lines 139, 141: Expected error (tag 'invalid_final_2')
+Line 40: Unexpected errors ['overloads_invalid.py:40:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.']
+Line 51: Unexpected errors ['overloads_invalid.py:51:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.']
+Line 124: Unexpected errors ['overloads_invalid.py:124:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
 """
 output = """
-overloads_invalid.py:13:0 Incompatible overload [43]: At least two overload signatures must be present.
-overloads_invalid.py:25:0 Missing overload implementation [42]: Overloaded function `func2` must have an implementation.
-overloads_invalid.py:38:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.
-overloads_invalid.py:49:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.
-overloads_invalid.py:62:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.not_abstract` must have an implementation.
-overloads_invalid.py:78:4 Incompatible overload [43]: The implementation of `C.func5` does not accept all possible arguments of overload defined on line `78`.
-overloads_invalid.py:83:4 Incompatible overload [43]: The implementation of `C.func5` does not accept all possible arguments of overload defined on line `83`.
-overloads_invalid.py:86:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
-overloads_invalid.py:91:4 Incompatible overload [43]: The implementation of `C.func6` does not accept all possible arguments of overload defined on line `91`.
-overloads_invalid.py:96:4 Incompatible overload [43]: The implementation of `C.func6` does not accept all possible arguments of overload defined on line `96`.
-overloads_invalid.py:99:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:15:0 Incompatible overload [43]: At least two overload signatures must be present.
+overloads_invalid.py:27:0 Missing overload implementation [42]: Overloaded function `func2` must have an implementation.
+overloads_invalid.py:40:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.
+overloads_invalid.py:51:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.
+overloads_invalid.py:64:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.not_abstract` must have an implementation.
+overloads_invalid.py:80:4 Incompatible overload [43]: The implementation of `C.func5` does not accept all possible arguments of overload defined on line `80`.
+overloads_invalid.py:85:4 Incompatible overload [43]: The implementation of `C.func5` does not accept all possible arguments of overload defined on line `85`.
+overloads_invalid.py:88:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:97:4 Incompatible overload [43]: The implementation of `C.func6` does not accept all possible arguments of overload defined on line `97`.
+overloads_invalid.py:97:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:124:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:133:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_invalid.py:155:4 Invalid override [40]: `overloads_invalid.Child.final_method` cannot override final method defined in `Base`.
 """

conformance/results/pyright/overloads_invalid.toml

@@ -1,24 +1,34 @@
-conformant = "Pass"
-conformance_automated = "Pass"
+conformant = "Partial"
+notes = """
+Allows @final on all overloads and implementation; should be implementation-only.
+"""
+conformance_automated = "Fail"
 errors_diff = """
+Lines 139, 141: Expected error (tag 'invalid_final_2')
 """
 output = """
-overloads_invalid.py:13:5 - error: "func1" is marked as overload, but additional overloads are missing (reportInconsistentOverload)
-overloads_invalid.py:25:5 - error: "func2" is marked as overload, but no implementation is provided (reportNoOverloadImplementation)
-overloads_invalid.py:62:9 - error: "not_abstract" is marked as overload, but no implementation is provided (reportNoOverloadImplementation)
-overloads_invalid.py:78:9 - error: Overloads for "func5" use @staticmethod inconsistently (reportInconsistentOverload)
-overloads_invalid.py:86:9 - error: Overloaded implementation is not consistent with signature of overload 1
+overloads_invalid.py:15:5 - error: "func1" is marked as overload, but additional overloads are missing (reportInconsistentOverload)
+overloads_invalid.py:27:5 - error: "func2" is marked as overload, but no implementation is provided (reportNoOverloadImplementation)
+overloads_invalid.py:64:9 - error: "not_abstract" is marked as overload, but no implementation is provided (reportNoOverloadImplementation)
+overloads_invalid.py:80:9 - error: Overloads for "func5" use @staticmethod inconsistently (reportInconsistentOverload)
+overloads_invalid.py:88:9 - error: Overloaded implementation is not consistent with signature of overload 1
   Type "(self: Self@C, x: int | str) -> (int | str)" is not assignable to type "(x: int) -> int"
     Parameter name mismatch: "x" versus "self"
     Parameter 1: type "int" is incompatible with type "Self@C"
       Type "int" is not assignable to type "Self@C"
     Extra parameter "x" (reportInconsistentOverload)
-overloads_invalid.py:86:9 - error: Overloaded implementation is not consistent with signature of overload 2
+overloads_invalid.py:88:9 - error: Overloaded implementation is not consistent with signature of overload 2
   Type "(self: Self@C, x: int | str) -> (int | str)" is not assignable to type "(x: str) -> str"
     Parameter name mismatch: "x" versus "self"
     Parameter 1: type "str" is incompatible with type "Self@C"
       Type "str" is not assignable to type "Self@C"
     Extra parameter "x" (reportInconsistentOverload)
-overloads_invalid.py:91:9 - error: Overloads for "func6" use @classmethod inconsistently (reportInconsistentOverload)
-overloads_invalid.py:99:15 - warning: Instance methods should take a "self" parameter (reportSelfClsParameterName)
+overloads_invalid.py:93:9 - error: Overloads for "func6" use @classmethod inconsistently (reportInconsistentOverload)
+overloads_invalid.py:97:15 - warning: Instance methods should take a "self" parameter (reportSelfClsParameterName)
+overloads_invalid.py:129:9 - error: Overload for "invalid_final" is marked @final but implementation is not (reportInconsistentOverload)
+overloads_invalid.py:155:9 - error: Method "final_method" cannot override final method defined in class "Base" (reportIncompatibleMethodOverride)
+overloads_invalid.py:155:9 - error: Method "final_method" overrides class "Base" in an incompatible manner
+  Return type mismatch: base method returns type "int", override returns type "int | str"
+    Type "int | str" is not assignable to type "int"
+      "str" is not assignable to "int" (reportIncompatibleMethodOverride)
 """

conformance/results/pytype/overloads_invalid.toml

@@ -4,42 +4,109 @@ Does not reject a function with a single @overload signature.
 Does not reject a function with @overload signature but no implementation.
 Does not allow an overload with no implementation in a Protocol or an abstract base class.
 Does not error on overloads inconsistently decorated with `@staticmethod` or `@classmethod`.
+Does not enforce any rules on location of @final decorator.
 """
 conformance_automated = "Fail"
 errors_diff = """
-Lines 12, 13: Expected error (tag 'func1')
-Lines 24, 25: Expected error (tag 'func2')
-Lines 61, 62: Expected error (tag 'not_abstract')
-Lines 76, 78, 83, 86: Expected error (tag 'func5')
-Lines 89, 91, 96, 99: Expected error (tag 'func6')
-Line 44: Unexpected errors ["overloads_invalid.py:44:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func3: @typing.overload-decorated 'MyProto.func3' object is not callable [not-callable]"]
-Line 56: Unexpected errors ["overloads_invalid.py:56:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func4: @typing.overload-decorated 'MyAbstractBase.func4' object is not callable [not-callable]"]
-Line 68: Unexpected errors ["overloads_invalid.py:68:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in not_abstract: @typing.overload-decorated 'MyAbstractBase.not_abstract' object is not callable [not-callable]"]
-Line 79: Unexpected errors ['overloads_invalid.py:79:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func5: bad return type [bad-return-type]']
-Line 84: Unexpected errors ['overloads_invalid.py:84:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func5: bad return type [bad-return-type]']
+Lines 14, 15: Expected error (tag 'func1')
+Lines 26, 27: Expected error (tag 'func2')
+Lines 63, 64: Expected error (tag 'not_abstract')
+Lines 78, 80, 85, 88: Expected error (tag 'func5')
+Lines 91, 93, 97, 101: Expected error (tag 'func6')
+Lines 127, 129, 133: Expected error (tag 'invalid_final')
+Lines 139, 141: Expected error (tag 'invalid_final_2')
+Line 6: Unexpected errors ['overloads_invalid.py:6:1: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in <module>: typing.override not supported yet [not-supported-yet]']
+Line 46: Unexpected errors ["overloads_invalid.py:46:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func3: @typing.overload-decorated 'MyProto.func3' object is not callable [not-callable]"]
+Line 58: Unexpected errors ["overloads_invalid.py:58:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func4: @typing.overload-decorated 'MyAbstractBase.func4' object is not callable [not-callable]"]
+Line 70: Unexpected errors ["overloads_invalid.py:70:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in not_abstract: @typing.overload-decorated 'MyAbstractBase.not_abstract' object is not callable [not-callable]"]
+Line 81: Unexpected errors ['overloads_invalid.py:81:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func5: bad return type [bad-return-type]']
+Line 86: Unexpected errors ['overloads_invalid.py:86:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in func5: bad return type [bad-return-type]']
+Line 125: Unexpected errors ['overloads_invalid.py:125:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in final_method: bad return type [bad-return-type]', 'overloads_invalid.py:125:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in final_method: bad return type [bad-return-type]']
+Line 137: Unexpected errors ['overloads_invalid.py:137:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in invalid_final: bad return type [bad-return-type]', 'overloads_invalid.py:137:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in invalid_final: bad return type [bad-return-type]']
+Line 151: Unexpected errors ['overloads_invalid.py:151:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in invalid_final_2: bad return type [bad-return-type]', 'overloads_invalid.py:151:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in invalid_final_2: bad return type [bad-return-type]']
+Line 156: Unexpected errors ['overloads_invalid.py:156:9: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in final_method: bad return type [bad-return-type]']
 """
 output = """
-overloads_invalid.py:44:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func3: @typing.overload-decorated 'MyProto.func3' object is not callable [not-callable]
+overloads_invalid.py:6:1: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in <module>: typing.override not supported yet [not-supported-yet]
+
+from typing import (
+\u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+    final,
+\u001b[1m\u001b[31m~~~~~~~~~~\u001b[39m\u001b[0m
+    Protocol,
+\u001b[1m\u001b[31m~~~~~~~~~~~~~\u001b[39m\u001b[0m
+    overload,
+\u001b[1m\u001b[31m~~~~~~~~~~~~~\u001b[39m\u001b[0m
+    override,
+\u001b[1m\u001b[31m~~~~~~~~~~~~~\u001b[39m\u001b[0m
+)
+\u001b[1m\u001b[31m~\u001b[39m\u001b[0m
+
+overloads_invalid.py:46:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func3: @typing.overload-decorated 'MyProto.func3' object is not callable [not-callable]
 
         ...
         \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
 
-overloads_invalid.py:56:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func4: @typing.overload-decorated 'MyAbstractBase.func4' object is not callable [not-callable]
+overloads_invalid.py:58:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func4: @typing.overload-decorated 'MyAbstractBase.func4' object is not callable [not-callable]
 
         ...
         \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
 
-overloads_invalid.py:68:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in not_abstract: @typing.overload-decorated 'MyAbstractBase.not_abstract' object is not callable [not-callable]
+overloads_invalid.py:70:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in not_abstract: @typing.overload-decorated 'MyAbstractBase.not_abstract' object is not callable [not-callable]
 
         ...
         \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
 
-overloads_invalid.py:79:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func5: bad return type [bad-return-type]
+overloads_invalid.py:81:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func5: bad return type [bad-return-type]
 
         ...
         \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
 
-overloads_invalid.py:84:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func5: bad return type [bad-return-type]
+overloads_invalid.py:86:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in func5: bad return type [bad-return-type]
+
+        ...
+        \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:125:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in final_method: bad return type [bad-return-type]
+
+        ...
+        \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:125:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in final_method: bad return type [bad-return-type]
+
+        ...
+        \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:137:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in invalid_final: bad return type [bad-return-type]
+
+        ...
+        \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:137:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in invalid_final: bad return type [bad-return-type]
+
+        ...
+        \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:151:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in invalid_final_2: bad return type [bad-return-type]
+
+        ...
+        \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:151:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in invalid_final_2: bad return type [bad-return-type]
+
+        ...
+        \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:154:1: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in <module>: Class Child overrides final method final_method, defined in base class Base [final-error]
+
+class Child(Base):  # E[override-final]
+\u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+    def final_method(self, x: int | str) -> int | str:  # E[override-final] can't override final method
+\u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+        ...
+\u001b[1m\u001b[31m~~~~~~~~~~~\u001b[39m\u001b[0m
+
+overloads_invalid.py:156:9: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in final_method: bad return type [bad-return-type]
 
         ...
         \u001b[1m\u001b[31m~~~\u001b[39m\u001b[0m

conformance/results/pytype/version.toml

@@ -1,2 +1,2 @@
 version = "pytype 2024.10.11"
-test_duration = 29.9
+test_duration = 30.4