add tests for bool expansion (no checker does this)

Author: carljm

conformance/results/mypy/overloads_evaluation.toml

@@ -1,11 +1,14 @@
 conformant = "Partial"
 notes = """
 Does not pick a winning overload based on arity, prior to considering argument types.
+Does not expand boolean arguments to Literal[True] and Literal[False].
 """
 conformance_automated = "Fail"
 errors_diff = """
 Line 35: Unexpected errors ['overloads_evaluation.py:35: error: Expression is of type "Any", not "int"  [assert-type]']
 Line 41: Unexpected errors ['overloads_evaluation.py:41: error: Expression is of type "Any", not "str"  [assert-type]']
+Line 102: Unexpected errors ['overloads_evaluation.py:102: error: No overload variant of "expand_bool" matches argument type "bool"  [call-overload]']
+Line 103: Unexpected errors ['overloads_evaluation.py:103: error: Expression is of type "Any", not "Literal[0, 1]"  [assert-type]']
 """
 output = """
 overloads_evaluation.py:26: error: All overload variants of "example1" require at least one argument  [call-overload]
@@ -24,4 +27,9 @@ overloads_evaluation.py:40: note:     def example1(x: str) -> str
 overloads_evaluation.py:41: error: Expression is of type "Any", not "str"  [assert-type]
 overloads_evaluation.py:85: error: Argument 1 to "example2" has incompatible type "int | str"; expected "int"  [arg-type]
 overloads_evaluation.py:85: error: Argument 2 to "example2" has incompatible type "int | str"; expected "str"  [arg-type]
+overloads_evaluation.py:102: error: No overload variant of "expand_bool" matches argument type "bool"  [call-overload]
+overloads_evaluation.py:102: note: Possible overload variants:
+overloads_evaluation.py:102: note:     def expand_bool(x: Literal[False]) -> Literal[0]
+overloads_evaluation.py:102: note:     def expand_bool(x: Literal[True]) -> Literal[1]
+overloads_evaluation.py:103: error: Expression is of type "Any", not "Literal[0, 1]"  [assert-type]
 """

conformance/results/pyre/overloads_evaluation.toml

@@ -1,11 +1,17 @@
-conformant = "Pass"
-conformance_automated = "Pass"
+conformant = "Partial"
+notes = """
+Does not expand boolean arguments to Literal[True] and Literal[False].
+"""
+conformance_automated = "Fail"
 errors_diff = """
+Line 85: Expected 1 errors
+Line 102: Unexpected errors ['overloads_evaluation.py:102:23 Incompatible parameter type [6]: In call `expand_bool`, for 1st positional argument, expected `typing_extensions.Literal[False]` but got `bool`.']
+Line 103: Unexpected errors ['overloads_evaluation.py:103:4 Assert type [70]: Expected `Union[typing_extensions.Literal[0], typing_extensions.Literal[1]]` but got `typing_extensions.Literal[0]`.']
 """
 output = """
 overloads_evaluation.py:26:0 Missing argument [20]: Call `example1` expects argument `x`.
 overloads_evaluation.py:34:19 Incompatible parameter type [6]: In call `example1`, for 2nd positional argument, expected `str` but got `int`.
 overloads_evaluation.py:40:16 Incompatible parameter type [6]: In call `example1`, for 1st positional argument, expected `str` but got `int`.
-overloads_evaluation.py:85:13 Incompatible parameter type [6]: In call `example2`, for 1st positional argument, expected `int` but got `Union[int, str]`.
-overloads_evaluation.py:85:16 Incompatible parameter type [6]: In call `example2`, for 2nd positional argument, expected `str` but got `Union[int, str]`.
+overloads_evaluation.py:102:23 Incompatible parameter type [6]: In call `expand_bool`, for 1st positional argument, expected `typing_extensions.Literal[False]` but got `bool`.
+overloads_evaluation.py:103:4 Assert type [70]: Expected `Union[typing_extensions.Literal[0], typing_extensions.Literal[1]]` but got `typing_extensions.Literal[0]`.
 """

conformance/results/pyre/version.toml

@@ -1,2 +1,2 @@
 version = "pyre 0.9.23"
-test_duration = 6.1
+test_duration = 6.7

conformance/results/pyright/overloads_evaluation.toml

@@ -1,6 +1,11 @@
-conformant = "Pass"
-conformance_automated = "Pass"
+conformant = "Partial"
+notes = """
+Does not expand boolean arguments to Literal[True] and Literal[False].
+"""
+conformance_automated = "Fail"
 errors_diff = """
+Line 102: Unexpected errors ['overloads_evaluation.py:102:12 - error: No overloads for "expand_bool" match the provided arguments (reportCallIssue)', 'overloads_evaluation.py:102:24 - error: Argument of type "bool" cannot be assigned to parameter "x" of type "Literal[True]" in function "expand_bool"']
+Line 103: Unexpected errors ['overloads_evaluation.py:103:17 - error: "assert_type" mismatch: expected "Literal[0, 1]" but received "Unknown" (reportAssertTypeFailure)']
 """
 output = """
 overloads_evaluation.py:26:1 - error: No overloads for "example1" match the provided arguments
@@ -16,4 +21,8 @@ overloads_evaluation.py:85:14 - error: Argument of type "int | str" cannot be as
 overloads_evaluation.py:85:17 - error: Argument of type "int | str" cannot be assigned to parameter "y" of type "int" in function "example2"
   Type "int | str" is not assignable to type "int"
     "str" is not assignable to "int" (reportArgumentType)
+overloads_evaluation.py:102:12 - error: No overloads for "expand_bool" match the provided arguments (reportCallIssue)
+overloads_evaluation.py:102:24 - error: Argument of type "bool" cannot be assigned to parameter "x" of type "Literal[True]" in function "expand_bool"
+  "bool" is not assignable to type "Literal[True]" (reportArgumentType)
+overloads_evaluation.py:103:17 - error: "assert_type" mismatch: expected "Literal[0, 1]" but received "Unknown" (reportAssertTypeFailure)
 """

conformance/results/pyright/version.toml

@@ -1,2 +1,2 @@
 version = "pyright 1.1.391"
-test_duration = 1.6
+test_duration = 1.5

conformance/results/pytype/overloads_evaluation.toml

@@ -1,7 +1,7 @@
 conformant = "Partial"
 notes = """
 Does not pick a winning overload based on arity, prior to considering argument types.
-Does not perform argument expansion on unions and union return types of all matching overloads.
+Does not perform argument expansion and union return types of all matching overloads.
 """
 conformance_automated = "Fail"
 errors_diff = """
@@ -11,6 +11,9 @@ Line 35: Unexpected errors ['overloads_evaluation.py:35:1: \\x1b[1m\\x1b[31merro
 Line 41: Unexpected errors ['overloads_evaluation.py:41:1: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in <module>: Any [assert-type]']
 Line 59: Unexpected errors ['overloads_evaluation.py:59:12: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in example2: bad return type [bad-return-type]']
 Line 78: Unexpected errors ['overloads_evaluation.py:78:5: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in _: str [assert-type]']
+Line 99: Unexpected errors ['overloads_evaluation.py:99:5: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in expand_bool: bad return type [bad-return-type]', 'overloads_evaluation.py:99:5: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in expand_bool: bad return type [bad-return-type]']
+Line 102: Unexpected errors ['overloads_evaluation.py:102:12: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in _: Function expand_bool was called with the wrong arguments [wrong-arg-types]']
+Line 103: Unexpected errors ['overloads_evaluation.py:103:5: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in _: Any [assert-type]']
 """
 output = """
 overloads_evaluation.py:22:12: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in example1: bad return type [bad-return-type]
@@ -55,4 +58,24 @@ overloads_evaluation.py:78:5: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in _:
     assert_type(ret1, int | str)
     \u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
 
+overloads_evaluation.py:99:5: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in expand_bool: bad return type [bad-return-type]
+
+    return int(x)
+    \u001b[1m\u001b[31m~~~~~~~~~~~~~\u001b[39m\u001b[0m
+
+overloads_evaluation.py:99:5: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in expand_bool: bad return type [bad-return-type]
+
+    return int(x)
+    \u001b[1m\u001b[31m~~~~~~~~~~~~~\u001b[39m\u001b[0m
+
+overloads_evaluation.py:102:12: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in _: Function expand_bool was called with the wrong arguments [wrong-arg-types]
+
+    ret1 = expand_bool(v)
+           \u001b[1m\u001b[31m~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+
+overloads_evaluation.py:103:5: \u001b[1m\u001b[31merror\u001b[39m\u001b[0m: in _: Any [assert-type]
+
+    assert_type(ret1, Literal[0, 1])
+    \u001b[1m\u001b[31m~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\u001b[39m\u001b[0m
+
 """

conformance/results/pytype/version.toml

@@ -1,2 +1,2 @@
 version = "pytype 2024.10.11"
-test_duration = 31.5
+test_duration = 31.2

conformance/results/results.html

@@ -162,13 +162,13 @@ <h3>Python Type System Conformance Test Results</h3>
 <div class='tc-time'>1.7sec</div>
 </th>
 <th class='tc-header'><div class='tc-name'>pyright 1.1.391</div>
-<div class='tc-time'>1.6sec</div>
+<div class='tc-time'>1.5sec</div>
 </th>
 <th class='tc-header'><div class='tc-name'>pyre 0.9.23</div>
-<div class='tc-time'>6.1sec</div>
+<div class='tc-time'>6.7sec</div>
 </th>
 <th class='tc-header'><div class='tc-name'>pytype 2024.10.11</div>
-<div class='tc-time'>31.5sec</div>
+<div class='tc-time'>31.2sec</div>
 </th>
 </tr>
 <tr><th class="column" colspan="5">
@@ -691,10 +691,10 @@ <h3>Python Type System Conformance Test Results</h3>
 <th class="column col2 not-conformant"><div class="hover-text">Fail<span class="tooltip-text" id="bottom"><p>Does not enforce any of the specified rules regarding overload definitions.</p></span></div></th>
 </tr>
 <tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;overloads_evaluation</th>
-<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not pick a winning overload based on arity, prior to considering argument types.</p></span></div></th>
-<th class="column col2 conformant">Pass</th>
-<th class="column col2 conformant">Pass</th>
-<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not pick a winning overload based on arity, prior to considering argument types.</p><p>Does not perform argument expansion on unions and union return types of all matching overloads.</p></span></div></th>
+<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not pick a winning overload based on arity, prior to considering argument types.</p><p>Does not expand boolean arguments to Literal[True] and Literal[False].</p></span></div></th>
+<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not expand boolean arguments to Literal[True] and Literal[False].</p></span></div></th>
+<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not expand boolean arguments to Literal[True] and Literal[False].</p></span></div></th>
+<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not pick a winning overload based on arity, prior to considering argument types.</p><p>Does not perform argument expansion and union return types of all matching overloads.</p></span></div></th>
 </tr>
 <tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;overloads_overlap</th>
 <th class="column col2 conformant">Pass</th>

conformance/tests/overloads_evaluation.py

@@ -2,7 +2,7 @@
 Tests for evaluation of calls to overloaded functions.
 """
 
-from typing import assert_type, overload
+from typing import assert_type, Literal, overload
 
 
 # > Step 1: Examine the argument list to determine the number of
@@ -84,3 +84,20 @@ def _(v: int | str) -> None:
 def _(v: int | str) -> None:
     example2(v, v, 1)  # E: no overload matches (str, ..., ...)
 
+
+# > 2. ``bool`` should be expanded into ``Literal[True]`` and ``Literal[False]``.
+
+@overload
+def expand_bool(x: Literal[False]) -> Literal[0]:
+    ...
+
+@overload
+def expand_bool(x: Literal[True]) -> Literal[1]:
+    ...
+
+def expand_bool(x: bool) -> int:
+    return int(x)
+
+def _(v: bool) -> None:
+    ret1 = expand_bool(v)
+    assert_type(ret1, Literal[0, 1])