Skip to content

Commit 66eebb1

Browse files
committed
Removed code addressing #468
1 parent efa1214 commit 66eebb1

File tree

2 files changed

+0
-49
lines changed

2 files changed

+0
-49
lines changed

src/test_typing_extensions.py

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -7515,40 +7515,6 @@ def test_invalid_cases_before_3_11(self):
75157515
with self.assertRaises(TypeError):
75167516
ListOrSetT[(Generic[T], )]
75177517

7518-
def test_subscription_without_type_params(self):
7519-
Simple = TypeAliasType("Simple", int)
7520-
with self.assertRaises(TypeError, msg="Only generic type aliases are subscriptable"):
7521-
Simple[int]
7522-
with self.assertRaises(TypeError, msg="Only generic type aliases are subscriptable"):
7523-
Simple[[]]
7524-
with self.assertRaises(TypeError, msg="Only generic type aliases are subscriptable"):
7525-
Simple[()]
7526-
7527-
# A TypeVar in the value does not allow subscription
7528-
T = TypeVar('T')
7529-
MissingTypeParamsErr = TypeAliasType("MissingTypeParamsErr", List[T])
7530-
self.assertEqual(MissingTypeParamsErr.__type_params__, ())
7531-
self.assertEqual(MissingTypeParamsErr.__parameters__, ())
7532-
with self.assertRaises(TypeError, msg="Only generic type aliases are subscriptable"):
7533-
MissingTypeParamsErr[int]
7534-
with self.assertRaises(TypeError, msg="Only generic type aliases are subscriptable"):
7535-
MissingTypeParamsErr[[]]
7536-
with self.assertRaises(TypeError, msg="Only generic type aliases are subscriptable"):
7537-
MissingTypeParamsErr[()]
7538-
7539-
# However, providing type_params=() argument allows subscription
7540-
MissingTypeParams = TypeAliasType("MissingTypeParams", List[T], type_params=())
7541-
self.assertEqual(MissingTypeParams.__type_params__, ())
7542-
self.assertEqual(MissingTypeParams.__parameters__, ())
7543-
# These do not raise
7544-
MissingTypeParams[int]
7545-
MissingTypeParams[[]]
7546-
MissingTypeParams[()]
7547-
# These do not raise
7548-
Simple2 = TypeAliasType("Simple2", int, type_params=())
7549-
Simple2[int]
7550-
Simple2[[]]
7551-
Simple2[()]
75527518

75537519
def test_pickle(self):
75547520
global Alias

src/typing_extensions.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3526,19 +3526,6 @@ def _raise_attribute_error(self, name: str) -> Never:
35263526
def __repr__(self) -> str:
35273527
return self.__name__
35283528

3529-
def _is_subscriptable(self):
3530-
if len(self.__parameters__) > 0:
3531-
return True
3532-
if _should_collect_from_parameters(self.__value__):
3533-
if hasattr(typing, '_collect_type_vars'):
3534-
more_parameters = _collect_type_vars((self.__value__,),
3535-
(TypeVar, ParamSpec))
3536-
else:
3537-
more_parameters = _collect_parameters((self.__value__,))
3538-
if more_parameters:
3539-
return True
3540-
return False
3541-
35423529
if sys.version_info < (3, 11):
35433530
def _check_single_param(self, param, recursion=0):
35443531
# Allow [], [int], [int, str], [int, ...], [int, T]
@@ -3572,8 +3559,6 @@ def _check_parameters(self, parameters):
35723559
]
35733560

35743561
def __getitem__(self, parameters):
3575-
if len(self.__parameters__) == 0 and not self._is_subscriptable():
3576-
raise TypeError("Only generic type aliases are subscriptable")
35773562
if not isinstance(parameters, tuple):
35783563
parameters = (parameters,)
35793564
parameters = self._check_parameters(parameters)

0 commit comments

Comments
 (0)