Skip to content

Commit 9e72db2

Browse files
srittauAlexWaygood
andauthored
Apply suggestions from code review
Co-authored-by: Alex Waygood <[email protected]>
1 parent 687d453 commit 9e72db2

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/test_typing_extensions.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4113,8 +4113,8 @@ class WrongReader:
41134113
def readx(self, n: int) -> bytes:
41144114
return b""
41154115

4116-
assert isinstance(MyReader(), typing_extensions.Reader)
4117-
assert not isinstance(WrongReader(), typing_extensions.Reader)
4116+
self.assertIsInstance(MyReader(), typing_extensions.Reader)
4117+
self.assertNotIsInstance(WrongReader(), typing_extensions.Reader)
41184118

41194119
def test_writer_runtime_checkable(self):
41204120
class MyWriter:
@@ -4125,8 +4125,8 @@ class WrongWriter:
41254125
def writex(self, b: bytes) -> int:
41264126
return 0
41274127

4128-
assert isinstance(MyWriter(), typing_extensions.Writer)
4129-
assert not isinstance(WrongWriter(), typing_extensions.Writer)
4128+
self.assertIsInstance(MyWriter(), typing_extensions.Writer)
4129+
self.assertNotIsInstance(WrongWriter(), typing_extensions.Writer)
41304130

41314131

41324132
class Point2DGeneric(Generic[T], TypedDict):

src/typing_extensions.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -884,8 +884,6 @@ def write(self, data: T_contra, /) -> int:
884884
"""Write data to the output stream and return the number of items written."""
885885

886886

887-
888-
889887
_NEEDS_SINGLETONMETA = (
890888
not hasattr(typing, "NoDefault") or not hasattr(typing, "NoExtraItems")
891889
)

0 commit comments

Comments
 (0)