Just use git for checkout #506
Conversation
actions/checkout is repeatedly flaky See also actions/checkout#1951 On the other hand, plain git clone seems to work just fine and never has connection issues checking out the default branch Funnily enough, the YAML is shorter this way too
hauntsaninja
force-pushed
the
action-checkout
branch
from
e750f37 to
9b855af
Compare
|
I'm not sure what other repos I've seen that use actions/checkout on other repos. mypy_primer just uses git clone. This is the problematic branch https://github.com/actions/checkout/blob/main/src/git-source-provider.ts#L138 (when using actions/checkout on your current repo, ref gets set) |
We do it in flake8-pyi: https://github.com/PyCQA/flake8-pyi/blob/a528bc09991768c65fbbb6dd7936560d06df5682/.github/workflows/typeshed_primer.yml#L37 I don't remember ever seeing this issue over there, though admittedly that workflow runs less regularly than this one! |
|
We also do it in typeshed, and that workflow runs very regularly: https://github.com/python/typeshed/blob/2419d7520b821752c1181d2105a074ef24b9db81/.github/workflows/tests.yml#L181 |
|
Looks like the workflow is still having timeout issues, even with plain git clones: #508 I wonder if it's hitting some sort of rate limit? If so, maybe staggering tests or running them sequentially may help? |
|
Hmm. Well, at least it's easy to add retries now: #509 |
4 participants
actions/checkout is repeatedly flaky. See also actions/checkout#1951
On the other hand, plain git clone seems to work just fine and never has connection issues checking out the default branch or whatever. If we do still see issues, it'll also be much easier to add retries
Funnily enough, the YAML is shorter this way too