Apply suggestions from code review

Co-authored-by: VasigaranAndAngel <[email protected]>

Author: python357-1

tagstudio/src/core/settings/libsettings.py

@@ -27,7 +27,7 @@ def open(path_value: Path | str) -> "LibSettings":
                     return LibSettings(**settings_data)
 
         # either settings file did not exist or was empty - either way, use default settings
-        settings = LibSettings(**dict(filename=str(path)))
+        settings = LibSettings(filename=str(path))
         return settings
 
     def save(self):

tagstudio/src/core/settings/tssettings.py

@@ -30,7 +30,7 @@ def read_settings(path: Path | str) -> "TSSettings":
                     settings = TSSettings(**settings_data)
                     return settings
 
-        return TSSettings(**dict(filename=str(path)))
+        return TSSettings(filename=str(path))
 
     def save(self, path: Path | str | None = None) -> None:
         path_value: Path = Path(path) if isinstance(path, str) else Path(self.filename)

tagstudio/src/core/tscacheddata.py

@@ -44,7 +44,7 @@ def open(path_value: Path | str | None = None) -> "TSCachedData":
                     logger.info("opening cache file at ", cache_location=path)
                     return TSCachedData(**cache_data)
 
-        return TSCachedData(**dict(path=str(default_cache_location)))
+        return TSCachedData(path=str(default_cache_location))
 
     def save(self):
         with open(self.path, "w") as f:

tagstudio/src/qt/modals/file_extension.py

@@ -73,7 +73,7 @@ def __init__(self, library: "Library"):
             lambda text: self.mode_combobox.setItemText(1, text), "ignore_list.mode.exclude"
         )
 
-        is_exclude_list = int(bool(self.lib.settings.is_exclude_list))
+        is_exclude_list = int(self.lib.settings.is_exclude_list)
 
         self.mode_combobox.setCurrentIndex(is_exclude_list)
         self.mode_combobox.currentIndexChanged.connect(lambda i: self.update_list_mode(i))