feat: finish basic settings menu

Author: python357-1

tagstudio/src/core/settings/tssettings.py

@@ -1,16 +1,16 @@
 from pathlib import Path
+from typing import Any
 
 import toml
 from pydantic import BaseModel, Field
-from typing import Any
 
 
 # NOTE: pydantic also has a BaseSettings class (from pydantic-settings) that allows any settings
 # properties to be overwritten with environment variables. as tagstudio is not currently using
 # environment variables, i did not base it on that, but that may be useful in the future.
 class TSSettings(BaseModel):
     dark_mode: bool = Field(default=False)
-    language: str = Field(default="en-US")
+    language: str = Field(default="en")
 
     # settings from the old SettingItem enum
     open_last_loaded_on_startup: bool = Field(default=False)

tagstudio/src/core/tscacheddata.py

@@ -23,7 +23,6 @@ class TSCachedData(BaseModel):
     @staticmethod
     def open(path: str | None = None) -> "TSCachedData":
         file: str | None = None
-
         if path is None:
             if not Path(cache_dir).exists():
                 logger.info("Cache directory does not exist - creating", path=cache_dir)
@@ -33,7 +32,10 @@ def open(path: str | None = None) -> "TSCachedData":
                 open(cache_location, "w").close()
             file = str(cache_location)
         else:
-            file = path
+            if not Path(path).exists():
+                logger.info("Cache file does not exist - creating", path=path)
+                open(path, "w").close()
+            file = str(path)
 
         data = toml.load(file)
         data["path"] = str(path) if path is not None else str(cache_location)

tagstudio/src/qt/modals/settings_modal.py

@@ -1,4 +1,6 @@
 import copy
+from pathlib import Path
+from typing import Any
 
 from PySide6.QtWidgets import (
     QCheckBox,
@@ -7,9 +9,8 @@
     QLabel,
     QVBoxLayout,
 )
-from src.core.settings import TSSettings 
+from src.core.settings import TSSettings
 from src.qt.widgets.panel import PanelWidget
-from typing import Any
 
 
 class SettingsModal(PanelWidget):
@@ -19,20 +20,6 @@ def __init__(self, settings: TSSettings):
 
         self.main = QVBoxLayout(self)
 
-        # ---
-        self.darkMode_Label = QLabel()
-        self.darkMode_Value = QCheckBox()
-        self.darkMode_Row = QHBoxLayout()
-        self.darkMode_Row.addWidget(self.darkMode_Label)
-        self.darkMode_Row.addWidget(self.darkMode_Value)
-
-        self.darkMode_Label.setText("Dark Mode")
-        self.darkMode_Value.setChecked(self.tempSettings.dark_mode)
-
-        self.darkMode_Value.stateChanged.connect(
-            lambda state: setattr(self.tempSettings, "dark_mode", bool(state))
-        )
-
         # ---
         self.language_Label = QLabel()
         self.language_Value = QComboBox()
@@ -41,12 +28,8 @@ def __init__(self, settings: TSSettings):
         self.language_Row.addWidget(self.language_Value)
 
         self.language_Label.setText("Language")
-        language_list = [  # TODO: put this somewhere else
-            "en-US",
-            "en-GB",
-            "es-MX",
-            # etc...
-        ]
+        translations_folder = Path("tagstudio/resources/translations")
+        language_list = [x.stem for x in translations_folder.glob("*.json")]
         self.language_Value.addItems(language_list)
         self.language_Value.setCurrentIndex(language_list.index(self.tempSettings.language))
         self.language_Value.currentTextChanged.connect(
@@ -59,7 +42,7 @@ def __init__(self, settings: TSSettings):
         self.show_library_list_Row = QHBoxLayout()
         self.show_library_list_Row.addWidget(self.show_library_list_Label)
         self.show_library_list_Row.addWidget(self.show_library_list_Value)
-        self.show_library_list_Label.setText("Load library list on startup:")
+        self.show_library_list_Label.setText("Load library list on startup (requires restart):")
         self.show_library_list_Value.setChecked(self.tempSettings.show_library_list)
 
         self.show_library_list_Value.stateChanged.connect(

tagstudio/src/qt/translations.py

@@ -30,7 +30,7 @@ def value(self) -> str:
 
     @value.setter
     def value(self, value: str):
-        if self.__value != value:
+        if self.__value != value and value is not None:
             self.__value = value
             self.changed.emit(self.__value)
 

tagstudio/src/qt/ts_qt.py

@@ -183,10 +183,9 @@ def __init__(self, backend, args):
 
             self.settings = TSSettings.read_settings(path)
             logger.info(
-                "Config File not specified, using default one",
-                filename=self.settings.filename,
+                "Config File not specified, using default one", filename=self.settings.filename
             )
-
+        Translations.change_language(self.settings.language)
         self.cache = TSCachedData.open()
 
     def init_workers(self):
@@ -706,6 +705,7 @@ def open_settings_menu(self):
     def update_settings(self, settings: TSSettings):
         self.settings = settings
         self.settings.save(self.settings.filename)
+        Translations.change_language(self.settings.language)
 
     def select_all_action_callback(self):
         self.selected = list(range(0, len(self.frame_content)))

tagstudio/tests/example_settings.toml

@@ -1,2 +1,4 @@
-dark_mode = true
-language = "es-MX"
+language = "en"
+open_last_loaded_on_startup = false
+show_filenames_in_grid = true
+autoplay = false

tagstudio/tests/test_driver.py

@@ -18,7 +18,7 @@ def __init__(self, settings, cache: TSCachedData | None = None):
 
 def test_evaluate_path_empty():
     # Given
-    settings = TSSettings(**dict())
+    settings = TSSettings(**dict(filename=""))
     driver = TestDriver(settings)
 
     # When
@@ -30,7 +30,7 @@ def test_evaluate_path_empty():
 
 def test_evaluate_path_missing():
     # Given
-    settings = TSSettings(**dict())
+    settings = TSSettings(**dict(filename=""))
     driver = TestDriver(settings)
 
     # When
@@ -42,8 +42,8 @@ def test_evaluate_path_missing():
 
 def test_evaluate_path_last_lib_not_exists():
     # Given
-    settings = TSSettings(**dict())
-    cache = TSCachedData()
+    settings = TSSettings(**dict(filename=""))
+    cache = TSCachedData.open()
     cache.last_library = "/0/4/5/1/"
     driver = TestDriver(settings, cache)
 
@@ -63,10 +63,11 @@ def test_evaluate_path_last_lib_present():
         cache.save()
 
         makedirs(Path(tmpdir) / TS_FOLDER_NAME)
-        driver = TestDriver(TSSettings(**dict()), cache)
+        driver = TestDriver(
+            TSSettings(**dict(filename="", open_last_loaded_on_startup=True)), cache
+        )
 
         # When
         result = driver.evaluate_path(None)
-
         # Then
         assert result == LibraryStatus(success=True, library_path=Path(tmpdir))

tagstudio/tests/test_settings.py

@@ -7,5 +7,7 @@
 
 def test_read_settings():
     settings = TSSettings.read_settings(CWD.parent / "example_settings.toml")
-    assert settings.dark_mode
-    assert settings.language == "es-MX"
+    assert settings.language == "en"
+    assert not settings.open_last_loaded_on_startup
+    assert settings.show_filenames_in_grid
+    assert not settings.autoplay