Skip to content

Commit 20869c5

Browse files
committed
[libc++] fix views::all hard error on lvalue move only views instead of SFINAE
For an lvalue reference to a move only view x, views::all(x) gives hard error because the expression inside noexcept is not well formed and it is not SFINAE friendly. Given a move only view type `V`, and a concept ``` template <class R> concept can_all = requires { std::views::all(std::declval<R>()); }; ``` The expression `can_all<V&>` returns libstdc++: false msvc stl : false libc++ : error: static_cast from 'V' to 'typename decay<decltype((std::forward<V &>(__t)))>::type' (aka 'V') uses deleted function noexcept(noexcept(_LIBCPP_AUTO_CAST(std::forward<_Tp>(__t)))) The standard spec has its own problem, the spec says it is expression equivalent to `decay-copy(E)` but the spec of `decay-copy` does not have any constraint, which means the expression `decay-copy(declval<V&>())` is well-formed and the concept `can_all<V&>` should return true and should error when instantiating the function body of decay-copy. This is clearly wrong behaviour in the spec and we will probably create an LWG issue. But the libc++'s behaviour is clearly not correct. The `noexcept` is an "extension" in libc++ which is not in the spec, but the expression inside `noexpect` triggers hard error, which is not right. Reviewed By: #libc, ldionne, var-const Differential Revision: https://reviews.llvm.org/D128281
1 parent 1f88d80 commit 20869c5

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

libcxx/include/__ranges/all.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ namespace __all {
3939
[[nodiscard]] _LIBCPP_HIDE_FROM_ABI
4040
constexpr auto operator()(_Tp&& __t) const
4141
noexcept(noexcept(_LIBCPP_AUTO_CAST(std::forward<_Tp>(__t))))
42+
-> decltype(_LIBCPP_AUTO_CAST(std::forward<_Tp>(__t)))
4243
{
4344
return _LIBCPP_AUTO_CAST(std::forward<_Tp>(__t));
4445
}

libcxx/test/std/ranges/range.adaptors/range.all/all.pass.cpp

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,17 @@ struct CopyableView : std::ranges::view_base {
4949
static_assert(std::ranges::view<CopyableView<true>>);
5050
static_assert(std::ranges::view<CopyableView<false>>);
5151

52+
struct MoveOnlyView : std::ranges::view_base{
53+
MoveOnlyView() = default;
54+
MoveOnlyView(const MoveOnlyView&) = delete;
55+
MoveOnlyView& operator=(const MoveOnlyView&) = delete;
56+
MoveOnlyView(MoveOnlyView&&) = default;
57+
MoveOnlyView& operator=(MoveOnlyView&&) = default;
58+
59+
int* begin() const;
60+
int* end() const;
61+
};
62+
5263
struct Range {
5364
int start_;
5465
constexpr explicit Range(int start) noexcept : start_(start) {}
@@ -139,6 +150,11 @@ constexpr bool test() {
139150
{
140151
static_assert(!std::is_invocable_v<decltype(std::views::all)>);
141152
static_assert(!std::is_invocable_v<decltype(std::views::all), RandomAccessRange, RandomAccessRange>);
153+
154+
// `views::all(v)` is expression equivalent to `decay-copy(v)` if the decayed type
155+
// of `v` models `view`. If `v` is an lvalue-reference to a move-only view, the
156+
// expression should be ill-formed because `v` is not copyable
157+
static_assert(!std::is_invocable_v<decltype(std::views::all), MoveOnlyView&>);
142158
}
143159

144160
// Test that std::views::all is a range adaptor

0 commit comments

Comments
 (0)