PA-752: Catching the already used domain name exception and outputting something more readable than the stacktrace. by Nina, Sam

Author: SamBoyd

cli/website.py

@@ -7,6 +7,7 @@
 from tabulate import tabulate
 
 from pythonanywhere_core.website import Website
+from pythonanywhere_core.exceptions import SanityException
 
 
 app = typer.Typer(no_args_is_help=True)
@@ -32,7 +33,11 @@ def create(
     ],
 ):
     """Create an ASGI website"""
-    Website().create(domain_name=domain_name, command=command)
+    try:
+        Website().create(domain_name=domain_name, command=command)
+    except SanityException as e:
+        typer.echo(f"You already have a website for {domain_name}. Use the --nuke option to replace it.")
+        return
 
     typer.echo(
         snakesay(

tests/test_cli_website.py

@@ -5,6 +5,7 @@
 from typer.testing import CliRunner
 
 from cli.website import app
+from pythonanywhere_core.exceptions import SanityException
 
 
 runner = CliRunner()
@@ -114,6 +115,27 @@ def test_create_with_domain_and_command_creates_it(mock_website):
     assert "All done!" in result.stdout
 
 
+def test_create_with_failing_sanity_check(mock_website):
+    mock_website.return_value.create.side_effect = SanityException("You already have a website for this domain. Use the --nuke option to replace it.")
+    
+    result = runner.invoke(
+        app,
+        [
+            "create",
+            "-d",
+            "www.something.com",
+            "-c",
+            "some kind of server",
+        ],
+    )
+    assert result.exit_code == 0
+    mock_website.return_value.create.assert_called_once_with(
+        domain_name="www.something.com",
+        command="some kind of server"
+    )
+    assert "You already have a website for www.something.com. Use the --nuke option to replace it." in result.stdout
+
+
 def test_get_with_no_domain_lists_websites(mock_echo, mock_tabulate, mock_website, website_info):
     second_website_info = {"domain_name": "blah.com", "enabled": False}
     mock_website.return_value.list.return_value = [website_info, second_website_info]