fixes tasks creation for midnight tasks.

Author: filiplajszczak

pythonanywhere/task.py

@@ -97,7 +97,7 @@ def to_be_created(cls, *, command, minute, hour=None, disabled=False):
         task.command = command
         task.hour = hour
         task.minute = minute
-        task.interval = "daily" if hour else "hourly"
+        task.interval = "daily" if hour is not None else "hourly"
         task.enabled = not disabled
         return task
 
@@ -138,7 +138,7 @@ def create_schedule(self):
             "interval": self.interval,
             "minute": self.minute,
         }
-        if self.hour:
+        if self.hour is not None:
             params["hour"] = self.hour
 
         self.update_specs(self.schedule.create(params))

setup.py

@@ -9,7 +9,7 @@
 
 setup(
     name="pythonanywhere",
-    version="0.10.2",
+    version="0.10.3",
     description="PythonAnywhere helper tools for users",
     long_description=long_description,
     long_description_content_type="text/markdown",

tests/test_task.py

@@ -93,6 +93,19 @@ def test_creates_daily_task(self, mocker, task_specs):
         assert mock_create.call_args == call(
             {"command": "echo foo", "hour": 16, "minute": 0, "enabled": True, "interval": "daily"}
         )
+    def test_creates_daily_midnight_task(self, mocker, task_specs):
+        mock_create = mocker.patch("pythonanywhere.api.schedule.Schedule.create")
+        mock_create.return_value = task_specs
+        mock_update_specs = mocker.patch("pythonanywhere.task.Task.update_specs")
+        task = Task.to_be_created(command="echo foo", hour=0, minute=0, disabled=False)
+
+        task.create_schedule()
+
+        assert mock_update_specs.call_args == call(task_specs)
+        assert mock_create.call_count == 1
+        assert mock_create.call_args == call(
+            {"command": "echo foo", "hour": 0, "minute": 0, "enabled": True, "interval": "daily"}
+        )
 
 
 @pytest.mark.tasks